Changed order of actions in ObjectIDFromHex func (mongodb#637)

kubedb · Mar 17, 2022 · 9e82d55 · 9e82d55
1 parent fc179ac
commit 9e82d55
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/bson/primitive/objectid.go b/bson/primitive/objectid.go
@@ -73,15 +73,15 @@ func (id ObjectID) IsZero() bool {
 // ObjectIDFromHex creates a new ObjectID from a hex string. It returns an error if the hex string is not a
 // valid ObjectID.
 func ObjectIDFromHex(s string) (ObjectID, error) {
+	if len(s) != 24 {
+		return NilObjectID, ErrInvalidHex
+	}
+
 	b, err := hex.DecodeString(s)
 	if err != nil {
 		return NilObjectID, err
 	}
 
-	if len(b) != 12 {
-		return NilObjectID, ErrInvalidHex
-	}
-
 	var oid [12]byte
 	copy(oid[:], b[:])