Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable admission controllers for webhook server #165

Merged
merged 1 commit into from
May 5, 2018
Merged

Disable admission controllers for webhook server #165

merged 1 commit into from
May 5, 2018

Conversation

tamalsaha
Copy link
Member

Since 1.10 release admission options are enabled by default . This was not the case in 1.9 release. Admission plugins seem unnecessary for a webhook server. So, I am disabling it.

If this is left enabled, then RBAC permissions need to be updated accordingly.

- apiGroups:
  - admissionregistration.k8s.io
  resources:
    - mutatingwebhookconfigurations
    - validatingwebhookconfigurations
  verbs: ["get","list"]

Since [1.10 release](https://github.com/kubernetes/apiserver/blob/release-1.10/pkg/server/options/recommended.go#L43) admission options are enabled by default . This was not the case in 1.9 release. Admission plugins seem unnecessary for a webhook server. So, I am disabling it.

If this is left enabled, then RBAC permissions need to be updated accordingly.
```
- apiGroups:
  - admissionregistration.k8s.io
  resources:
    - mutatingwebhookconfigurations
    - validatingwebhookconfigurations
  verbs: ["get","list"]
```
@tamalsaha tamalsaha merged commit ff1133b into master May 5, 2018
@tamalsaha tamalsaha deleted the x7 branch May 5, 2018 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant