Add kafka api #998
Merged
Add kafka api #998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![kodiak-appscode[bot]](https://avatars.githubusercontent.com/in/92481?s=60&v=4){kind=small}
Signed-off-by: raihankhan <[email protected]>
Signed-off-by: raihankhan <[email protected]>
Signed-off-by: raihankhan <[email protected]>
Signed-off-by: raihankhan <[email protected]>
Signed-off-by: raihankhan <[email protected]>
Signed-off-by: raihankhan <[email protected]>
Signed-off-by: raihankhan <[email protected]>
Signed-off-by: raihankhan <[email protected]>
Signed-off-by: raihankhan <[email protected]>
Signed-off-by: raihankhan <[email protected]>
ArnobKumarSaha
requested changes
Dec 9, 2022
apis/kubedb/v1alpha2/constants.go
Outdated
| KafkaControllerListenersName = "controller.listener.names" | ||
| KafkaInterBrokerListener = "inter.broker.listener.name" | ||
| KafkaNodeRole = "process.roles" | ||
| ClusterID = "cluster.id" |
| } | ||
|
|
||
| func (k *Kafka) StandbyServiceName() string { | ||
| return meta_util.NameWithPrefix(k.ServiceName(), "standby") |
There was a problem hiding this comment.
Add a constant for "standby" ?
Comment on lines
+71
to
+72
| Storage *core.PersistentVolumeClaimSpec `json:"storage,omitempty"` | ||
|
|
There was a problem hiding this comment.
Lets add EphemeralStorage too.
EphemeralStorage *core.EmptyDirVolumeSource json:"ephemeralStorage,omitempty"``
There was a problem hiding this comment.
EphemeralStorage is handled with storage type. For now, It's not needed.
Comment on lines
63
to
68
| err := k.ValidateCreateOrUpdate() | ||
| if err != nil { | ||
| return err | ||
| } | ||
| return nil | ||
| } |
There was a problem hiding this comment.
just returning k.ValidateCreateOrUpdate() would be enough.
Same for the below function
| return nil | ||
| } | ||
|
|
||
| func (k *Kafka) ValidateCreateOrUpdate() error { |
There was a problem hiding this comment.
We also need to validate storage related stuffs.
Check this https://github.com/kubedb/mongodb/blob/master/pkg/admission/validator.go#L325
Signed-off-by: raihankhan <[email protected]>
Signed-off-by: raihankhan <[email protected]>
faem
approved these changes
Dec 11, 2022
ArnobKumarSaha
approved these changes
Dec 11, 2022
heheh13
reviewed
Dec 11, 2022
| // +optional | ||
| Deprecated bool `json:"deprecated,omitempty"` | ||
| // PSP names | ||
| PodSecurityPolicies KafkaVersionPodSecurityPolicy `json:"podSecurityPolicies"` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tamal Saha [email protected]