Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip storage secret validation for S3 & GCS #222

Merged
merged 4 commits into from
May 17, 2018
Merged

skip storage secret validation for S3 & GCS #222

merged 4 commits into from
May 17, 2018

Conversation

mirshahriar
Copy link
Contributor

@mirshahriar mirshahriar commented May 11, 2018 •
edited
Loading 

contexts:
- config:
    json: ""
    project_id: ""
  name: gcs
  provider: google
- config:
    auth_type: iam
  name: aws
  provider: s3
current-context: aws

When no credential is provided, IAM user credential is used.

@mirshahriar mirshahriar self-assigned this May 11, 2018
@codecov-io
Copy link

codecov-io commented May 11, 2018 •
edited
Loading

Codecov Report

Merging #222 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #222   +/-   ##
=======================================
  Coverage   33.69%   33.69%           
=======================================
  Files           3        3           
  Lines         368      368           
=======================================
  Hits          124      124           
  Misses        212      212           
  Partials       32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef349e6...51bdb5a. Read the comment docs.

@mirshahriar mirshahriar requested review from the-redback and tamalsaha and removed request for the-redback May 14, 2018 10:06
tamalsaha
tamalsaha reviewed May 16, 2018
View reviewed changes
apis/kubedb/v1alpha1/types.go Outdated
@@ -81,6 +81,7 @@ type LocalSpec struct {

type S3Spec struct {
Endpoint string `json:"endpoint,omitempty"`
Region string `json:"region,omitempty"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without Region, Stow returns error: access denied: Bucket Location. Something like this.

@tamalsaha tamalsaha merged commit 4fa0907 into master May 17, 2018
@tamalsaha tamalsaha deleted the use-iam branch August 16, 2018 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamalsaha tamalsaha tamalsaha approved these changes

@the-redback the-redback Awaiting requested review from the-redback

Assignees

@mirshahriar mirshahriar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mirshahriar @codecov-io @tamalsaha