Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate apiGroup for mutating and validating webhook #217

Merged
merged 5 commits into from
May 4, 2018
Merged

Conversation

the-redback
Copy link
Contributor

  • Separate apiGroup for mutating and validating webhook
  • Both name and namespace required for snapshotInit
  • Skip Handling Snapshot Items of DOrmantDB in case of Redis and Memcached.

@the-redback the-redback requested a review from tamalsaha May 4, 2018 14:13
@codecov-io
Copy link

codecov-io commented May 4, 2018

Codecov Report

Merging #217 into master will increase coverage by 0.36%.
The diff coverage is 37.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #217      +/-   ##
==========================================
+ Coverage   33.15%   33.51%   +0.36%     
==========================================
  Files           3        3              
  Lines         365      367       +2     
==========================================
+ Hits          121      123       +2     
  Misses        212      212              
  Partials       32       32
Impacted Files Coverage Δ
pkg/admission/snapshot/admission.go 42.22% <0%> (ø) ⬆️
pkg/admission/dormantdatabase/admission.go 28.3% <41.37%> (+0.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2893109...4f5aeaf. Read the comment docs.

@tamalsaha tamalsaha merged commit 06f741a into master May 4, 2018
@tamalsaha tamalsaha deleted the apigroup branch May 4, 2018 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants