feat: auto detect repositoryType #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
0xff-dev,
Abirdcfly,
bjwswang,
Lanture1064 and
nkwangleiGIT
bjwswang
reviewed
Oct 23, 2023
bjwswang
reviewed
Oct 23, 2023
bjwswang
reviewed
Oct 23, 2023
0xff-dev
reviewed
Oct 23, 2023
Abirdcfly
reviewed
Oct 24, 2023
Codecov Report
@@ Coverage Diff @@
## main #384 +/- ##
==========================================
- Coverage 27.30% 27.10% -0.21%
==========================================
Files 37 37
Lines 4509 4546 +37
==========================================
+ Hits 1231 1232 +1
- Misses 3175 3211 +36
Partials 103 103
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Abirdcfly
reviewed
Oct 24, 2023
bjwswang
reviewed
Oct 26, 2023
bjwswang
reviewed
Oct 26, 2023
bjwswang
reviewed
Oct 26, 2023
bjwswang
reviewed
Oct 26, 2023
controllers/repository_controller.go
Outdated
| @@ -142,7 +142,7 @@ func (r *RepositoryReconciler) checkInitial(ctx context.Context, logger logr.Log | |||
| } | |||
|
|
|||
| if v, ok := instanceDeepCopy.Labels[corev1alpha1.RepositoryTypeLabel]; !ok || v != instanceDeepCopy.Spec.RepositoryType { | |||
| instanceDeepCopy.Labels[corev1alpha1.RepositoryTypeLabel] = instanceDeepCopy.Spec.RepositoryType | |||
| instanceDeepCopy.Labels[corev1alpha1.RepositoryTypeLabel] = string(instanceDeepCopy.GetRepoType(r.Client)) | |||
There was a problem hiding this comment.
currType := string(instanceDeepCopy.GetRepoType(r.Client))
if v := instanceDeepCopy.Labels[corev1alpha1.RepositoryTypeLabel];v != currType {
instanceDeepCopy.Labels[corev1alpha1.RepositoryTypeLabel]
update = true
}Signed-off-by: zqq454224016 <[email protected]>
bjwswang
approved these changes
Oct 26, 2023
Abirdcfly
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it
Which issue(s) this PR fixes
Fixes #362
Special notes for your reviewer