Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sub update cant update cpl when cpl has created #382

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

Abirdcfly
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it

Which issue(s) this PR fixes

Fixes #381

Special notes for your reviewer

@Abirdcfly Abirdcfly temporarily deployed to Dev October 20, 2023 03:23 — with GitHub Actions Inactive
@Abirdcfly Abirdcfly temporarily deployed to Dev October 20, 2023 03:23 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #382 (18588f5) into main (7cee163) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #382      +/-   ##
==========================================
- Coverage   27.50%   27.45%   -0.06%     
==========================================
  Files          37       37              
  Lines        4475     4484       +9     
==========================================
  Hits         1231     1231              
- Misses       3141     3150       +9     
  Partials      103      103              
Files Coverage Δ
controllers/componentplan_controller.go 4.59% <0.00%> (-0.02%) ⬇️
controllers/subscription_controller.go 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Abirdcfly Abirdcfly temporarily deployed to Dev October 20, 2023 05:54 — with GitHub Actions Inactive
@Abirdcfly Abirdcfly temporarily deployed to Dev October 20, 2023 05:59 — with GitHub Actions Inactive
@Abirdcfly Abirdcfly temporarily deployed to Dev October 20, 2023 08:01 — with GitHub Actions Inactive
@Abirdcfly Abirdcfly temporarily deployed to Dev October 20, 2023 08:01 — with GitHub Actions Inactive
@Abirdcfly Abirdcfly temporarily deployed to Dev October 20, 2023 08:25 — with GitHub Actions Inactive
@Abirdcfly Abirdcfly temporarily deployed to Dev October 20, 2023 08:25 — with GitHub Actions Inactive
@Abirdcfly Abirdcfly temporarily deployed to Dev October 20, 2023 09:16 — with GitHub Actions Inactive
@Abirdcfly Abirdcfly temporarily deployed to Dev October 20, 2023 09:16 — with GitHub Actions Inactive
@Abirdcfly Abirdcfly temporarily deployed to Dev October 20, 2023 09:39 — with GitHub Actions Inactive
@Abirdcfly Abirdcfly temporarily deployed to Dev October 20, 2023 09:39 — with GitHub Actions Inactive
@Abirdcfly Abirdcfly marked this pull request as ready for review October 20, 2023 09:59
@Abirdcfly Abirdcfly requested a review from dayuy October 20, 2023 09:59
@Abirdcfly Abirdcfly temporarily deployed to Dev October 23, 2023 02:47 — with GitHub Actions Inactive
@Abirdcfly Abirdcfly temporarily deployed to Dev October 23, 2023 02:58 — with GitHub Actions Inactive
@bjwswang bjwswang merged commit d409b15 into kubebb:main Oct 24, 2023
19 of 20 checks passed
@Abirdcfly Abirdcfly deleted the fixsubupdate branch October 24, 2023 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After modifying the subscription, there was no corresponding change in the componentPlan.
3 participants