Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: tracking rating status #363

Merged
merged 1 commit into from
Oct 23, 2023
Merged

feat: tracking rating status #363

merged 1 commit into from
Oct 23, 2023

Conversation

zqq454224016
Copy link
Collaborator

What type of PR is this?

What this PR does / why we need it

Which issue(s) this PR fixes

Fixes #358

Special notes for your reviewer

@zqq454224016 zqq454224016 temporarily deployed to Dev September 22, 2023 07:57 — with GitHub Actions Inactive
@zqq454224016 zqq454224016 temporarily deployed to Dev September 22, 2023 07:57 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Sep 22, 2023 •
edited
Loading

Codecov Report

Merging #363 (3c8d014) into main (7cee163) will decrease coverage by 0.21%.
The diff coverage is 0.00%.

❗ Current head 3c8d014 differs from pull request most recent head ccf7ce0. Consider uploading reports for the commit ccf7ce0 to get more accurate results

@@            Coverage Diff             @@
##             main     #363      +/-   ##
==========================================
- Coverage   27.50%   27.30%   -0.21%     
==========================================
  Files          37       37              
  Lines        4475     4509      +34     
==========================================
  Hits         1231     1231              
- Misses       3141     3175      +34     
  Partials      103      103
Files Coverage Δ
api/v1alpha1/condition.go 100.00% <ø> (ø)
controllers/rating_controller.go 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zqq454224016 zqq454224016 temporarily deployed to Dev September 22, 2023 10:08 — with GitHub Actions Inactive
@zqq454224016 zqq454224016 temporarily deployed to Dev September 22, 2023 10:08 — with GitHub Actions Inactive
@zqq454224016 zqq454224016 temporarily deployed to Dev September 25, 2023 10:21 — with GitHub Actions Inactive
@zqq454224016 zqq454224016 temporarily deployed to Dev September 25, 2023 10:21 — with GitHub Actions Inactive
@zqq454224016 zqq454224016 temporarily deployed to Dev September 26, 2023 07:06 — with GitHub Actions Inactive
@zqq454224016 zqq454224016 temporarily deployed to Dev September 26, 2023 07:06 — with GitHub Actions Inactive
@zqq454224016 zqq454224016 temporarily deployed to Dev September 26, 2023 08:26 — with GitHub Actions Inactive
@zqq454224016 zqq454224016 temporarily deployed to Dev September 26, 2023 08:26 — with GitHub Actions Inactive
@zqq454224016 zqq454224016 temporarily deployed to Dev October 17, 2023 07:35 — with GitHub Actions Inactive
@zqq454224016 zqq454224016 requested a review from bjwswang October 17, 2023 07:51
@zqq454224016 zqq454224016 temporarily deployed to Dev October 17, 2023 07:56 — with GitHub Actions Inactive
@zqq454224016 zqq454224016 temporarily deployed to Dev October 17, 2023 08:04 — with GitHub Actions Inactive
@zqq454224016 zqq454224016 temporarily deployed to Dev October 17, 2023 08:21 — with GitHub Actions Inactive
@zqq454224016 zqq454224016 temporarily deployed to Dev October 17, 2023 08:36 — with GitHub Actions Inactive
bjwswang
bjwswang previously approved these changes Oct 18, 2023
View reviewed changes
@zqq454224016
Copy link
Collaborator Author

@0xff-dev @Abirdcfly pls review this pr.

Abirdcfly
Abirdcfly previously approved these changes Oct 23, 2023
View reviewed changes
controllers/rating_controller.go Outdated Show resolved Hide resolved
pkg/evaluator/evaluator.go Outdated Show resolved Hide resolved
@zqq454224016 zqq454224016 dismissed stale reviews from Abirdcfly and bjwswang via a28752a October 23, 2023 02:53
@zqq454224016 zqq454224016 force-pushed the main branch 2 times, most recently from a28752a to 6b9bd02 Compare October 23, 2023 02:54
@zqq454224016 zqq454224016 temporarily deployed to Dev October 23, 2023 03:04 — with GitHub Actions Inactive
@zqq454224016 zqq454224016 temporarily deployed to Dev October 23, 2023 03:04 — with GitHub Actions Inactive
@zqq454224016 zqq454224016 temporarily deployed to Dev October 23, 2023 07:53 — with GitHub Actions Inactive
@zqq454224016 zqq454224016 temporarily deployed to Dev October 23, 2023 07:53 — with GitHub Actions Inactive
@zqq454224016
feat: tracking rating status
ccf7ce0 
Signed-off-by: zqq454224016 <[email protected]>
@zqq454224016 zqq454224016 temporarily deployed to Dev October 23, 2023 08:26 — with GitHub Actions Inactive
@zqq454224016 zqq454224016 temporarily deployed to Dev October 23, 2023 08:26 — with GitHub Actions Inactive
@zqq454224016 zqq454224016 requested a review from bjwswang October 23, 2023 08:32
@bjwswang bjwswang merged commit 18c293a into kubebb:main Oct 23, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjwswang bjwswang bjwswang approved these changes

@Abirdcfly Abirdcfly Abirdcfly approved these changes

@Lanture1064 Lanture1064 Awaiting requested review from Lanture1064

@nkwangleiGIT nkwangleiGIT Awaiting requested review from nkwangleiGIT

@0xff-dev 0xff-dev Awaiting requested review from 0xff-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

track rating status
4 participants
@zqq454224016 @bjwswang @Abirdcfly @0xff-dev