Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add test cases for http_watcher #352

Merged
merged 1 commit into from
Sep 25, 2023
Merged

feat: add test cases for http_watcher #352

merged 1 commit into from
Sep 25, 2023

Conversation

0xff-dev
Copy link
Collaborator

What type of PR is this?

/kind test

What this PR does / why we need it

feat: add test cases for http_watcher

Which issue(s) this PR fixes

For #194

Special notes for your reviewer

@0xff-dev 0xff-dev temporarily deployed to Dev September 19, 2023 09:38 — with GitHub Actions Inactive
@0xff-dev 0xff-dev temporarily deployed to Dev September 19, 2023 09:38 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #352 (7f3f959) into main (d899a16) will increase coverage by 1.67%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #352      +/-   ##
==========================================
+ Coverage   26.16%   27.83%   +1.67%     
==========================================
  Files          38       41       +3     
  Lines        3769     4290     +521     
==========================================
+ Hits          986     1194     +208     
- Misses       2711     2995     +284     
- Partials       72      101      +29     

see 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@0xff-dev 0xff-dev changed the title feat: add test cases for http_watcher [WIP] feat: add test cases for http_watcher Sep 19, 2023
@0xff-dev 0xff-dev changed the title [WIP] feat: add test cases for http_watcher feat: add test cases for http_watcher Sep 20, 2023
@0xff-dev 0xff-dev temporarily deployed to Dev September 20, 2023 02:12 — with GitHub Actions Inactive
@0xff-dev 0xff-dev temporarily deployed to Dev September 20, 2023 02:26 — with GitHub Actions Inactive
Copy link
Collaborator

@bjwswang bjwswang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xff-dev rebase to latest

@0xff-dev 0xff-dev temporarily deployed to Dev September 22, 2023 05:50 — with GitHub Actions Inactive
@0xff-dev 0xff-dev temporarily deployed to Dev September 22, 2023 05:50 — with GitHub Actions Inactive
@bjwswang bjwswang merged commit 90c9a0e into kubebb:main Sep 25, 2023
@0xff-dev 0xff-dev deleted the http-watcher-test branch October 12, 2023 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants