feat:add a new filed EnableRating in repository

Signed-off-by: zqq454224016 <[email protected]>

api/v1alpha1/rating_types.go

@@ -95,6 +95,8 @@ type RatingStatus struct {
 	PipelineRuns map[string]PipelineRunStatus `json:"pipelineRuns,omitempty"`
 	// Evaluations contains the evaluator status with the `Dimension` as the key
 	Evaluations map[string]EvaluatorStatus `json:"evaluations,omitempty"`
+
+	ConditionedStatus `json:",inline"`
 }
 
 type EvaluatorStatus struct {

api/v1alpha1/repository_types.go

@@ -90,6 +90,9 @@ type RepositorySpec struct {
 
 	// KeywordLenLimit the keyword array length limit
 	KeywordLenLimit int `json:"keywordLenLimit,omitempty"`
+
+	// EnableRating enable component rating
+	EnableRating bool `json:"enableRating,omitempty"`
 }
 
 type PathOverride struct {

config/crd/bases/core.kubebb.k8s.com.cn_ratings.yaml

@@ -111,6 +111,44 @@ spec:
             type: object
           status:
             properties:
+              conditions:
+                description: Conditions of the resource.
+                items:
+                  description: A Condition that may apply to a resource.
+                  properties:
+                    lastSuccessfulTime:
+                      description: LastSuccessfulTime is repository Last Successful
+                        Update Time
+                      format: date-time
+                      type: string
+                    lastTransitionTime:
+                      description: LastTransitionTime is the last time this condition
+                        transitioned from one status to another.
+                      format: date-time
+                      type: string
+                    message:
+                      description: A Message containing details about this condition's
+                        last transition from one status to another, if any.
+                      type: string
+                    reason:
+                      description: A Reason for this condition's last transition from
+                        one status to another.
+                      type: string
+                    status:
+                      description: Status of this condition; is it currently True,
+                        False, or Unknown
+                      type: string
+                    type:
+                      description: Type of this condition. At most one of each condition
+                        type may apply to a resource at any point in time.
+                      type: string
+                  required:
+                  - lastTransitionTime
+                  - reason
+                  - status
+                  - type
+                  type: object
+                type: array
               evaluations:
                 additionalProperties:
                   properties:

config/crd/bases/core.kubebb.k8s.com.cn_repositories.yaml

@@ -43,6 +43,9 @@ spec:
                   set the username and password to secret, with the fields user and
                   password respectively.
                 type: string
+              enableRating:
+                description: EnableRating enable component rating
+                type: boolean
               filter:
                 items:
                   properties:

config/samples/core_v1alpha1_rating_3.yaml

@@ -0,0 +1,31 @@
+apiVersion: core.kubebb.k8s.com.cn/v1alpha1
+kind: Rating
+metadata:
+  name: disable-rating
+  namespace: kubebb-system
+spec:
+  evaluator:
+    llm: zhipuai
+  componentName: repository-kubebb-disablerating.kubebb-core
+  pipelineParams:
+    - pipelineName: component-reliability
+      dimension: "reliability"
+      params:
+        - name: URL
+          value:
+            type: string
+            stringVal: https://github.com/kubebb/components/releases/download/kubebb-core-v0.1.10/kubebb-core-v0.1.10.tgz
+            arrayVal: []
+            objectVal: {}
+        - name: COMPONENT_NAME
+          value:
+            stringVal: kubebb-core
+            type: string
+        - name: VERSION
+          value:
+            stringVal: v0.1.10
+            type: string
+        - name: REPOSITORY_NAME
+          value:
+            stringVal: repository-kubebb-disablerating
+            type: string

config/samples/core_v1alpha1_repository_kubebb.yaml

@@ -5,6 +5,7 @@ metadata:
   namespace: kubebb-system
 spec:
   url: https://kubebb.github.io/components
+  enableRating: true
   pullStategy:
     intervalSeconds: 120
     retry: 5

config/samples/core_v1alpha1_repository_kubebb_2.yaml

@@ -0,0 +1,11 @@
+apiVersion: core.kubebb.k8s.com.cn/v1alpha1
+kind: Repository
+metadata:
+  name: repository-kubebb-disablerating
+  namespace: kubebb-system
+spec:
+  url: https://kubebb.github.io/components
+  enableRating: false
+  pullStategy:
+    intervalSeconds: 120
+    retry: 5

config/samples/rating_test.sh

@@ -147,7 +147,7 @@ function waitRatingDone() {
 	namespace=$1
 	ratingName=$2
 	START_TIME=$(date +%s)
-	sleep 2 # wait for operator patch status. avoid 0=0 situations
+	sleep 2 # wait for operator patch status. avoid 0=0 situationss
 	while true; do
 		complete=$(kubectl -n${namespace} get rating ${ratingName} -ojson --ignore-not-found=true | jq '.status.pipelineRuns' | jq '{l:length,o:map(select(.conditions[0].type=="Succeeded" and .conditions[0].status=="True"))|length}' | jq '.l == .o')
 		if [[ $complete == "true" ]]; then
@@ -164,6 +164,30 @@ function waitRatingDone() {
 	done
 }
 
+function waitRatingFail() {
+	namespace=$1
+	ratingName=$2
+	START_TIME=$(date +%s)
+	sleep 2 # wait for operator patch status. avoid 0=0 situations
+	while true; do
+		status=$(kubectl -n${namespace} get rating ${ratingName} -ojson --ignore-not-found=true | jq -r '.status.conditions[0].status')
+		type=$(kubectl -n${namespace} get rating ${ratingName} -ojson --ignore-not-found=true | jq -r '.status.conditions[0].type')
+		message=$(kubectl -n${namespace} get rating ${ratingName} -ojson --ignore-not-found=true | jq -r '.status.conditions[0].message')
+		if [[ $status == "False" && $type == "Ready" && $message == "Rating disabled in component's repository" ]]; then
+			echo "rating ${ratingName} task incompleted"
+			break
+		fi
+		CURRENT_TIME=$(date +%s)
+		ELAPSED_TIME=$((CURRENT_TIME - START_TIME))
+		if [ $ELAPSED_TIME -gt $TimeoutSeconds ]; then
+			error "Timeout reached"
+			exit 1
+		fi
+		sleep 5
+	done
+
+}
+
 function waitEvaluationsDone() {
 	namespace=$1
 	ratingName=$2
@@ -316,4 +340,13 @@ if [ -n "$LLM_API_KEY" ]; then
 	waitEvaluationsDone "kubebb-system" "two-dimension-rating" "security"
 fi
 
+info "8 verify repository with disabled rating"
+info "8.1 add kubebb repository with enableRating false"
+kubectl apply -f config/samples/core_v1alpha1_repository_kubebb_2.yaml
+waitComponentStatus "kubebb-system" "repository-kubebb-disablerating.kubebb-core"
+
+info "8.2 verify rating"
+kubectl apply -f config/samples/core_v1alpha1_rating_3.yaml
+waitRatingFail "kubebb-system" "disable-rating"
+
 info "all finished! ✅"

controllers/rating_controller.go

@@ -23,6 +23,7 @@ import (
 	"github.com/go-logr/logr"
 	arcadiav1 "github.com/kubeagi/arcadia/api/v1alpha1"
 	"github.com/tektoncd/pipeline/pkg/apis/pipeline/v1beta1"
+	v1 "k8s.io/api/core/v1"
 	"k8s.io/apimachinery/pkg/api/errors"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/runtime"
@@ -110,6 +111,29 @@ func (r RatingReconciler) ratingChecker(ctx context.Context, instance *corev1alp
 	if err := r.Client.Get(ctx, types.NamespacedName{Namespace: instance.Namespace, Name: instance.Spec.ComponentName}, &component); err != nil {
 		return false, err
 	}
+
+	repository := corev1alpha1.Repository{}
+	if err := r.Client.Get(ctx, types.NamespacedName{Namespace: instance.Namespace, Name: component.Status.RepositoryRef.Name}, &repository); err != nil {
+		return false, err
+	}
+	if !repository.Spec.EnableRating {
+		instanceDeepCopy := instance.DeepCopy()
+		cond := corev1alpha1.Condition{
+			Status:             v1.ConditionFalse,
+			LastTransitionTime: metav1.Now(),
+			Reason:             corev1alpha1.ReasonReconcileError,
+			Message:            "Rating disabled in component's repository",
+			Type:               corev1alpha1.TypeReady,
+		}
+		instanceDeepCopy.Status.ConditionedStatus = corev1alpha1.ConditionedStatus{
+			Conditions: []corev1alpha1.Condition{cond},
+		}
+		if err := r.Client.Status().Patch(ctx, instanceDeepCopy, client.MergeFrom(instance)); err != nil {
+			return false, err
+		}
+		return false, nil
+	}
+
 	if v, ok := instance.Labels[corev1alpha1.RatingRepositoryLabel]; !ok || v != component.Labels[corev1alpha1.ComponentRepositoryLabel] {
 		instance.Labels[corev1alpha1.RatingRepositoryLabel] = component.Labels[corev1alpha1.ComponentRepositoryLabel]
 		updateLabel = true