Adding instructions for using pre-exisiting NFS #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Marques <[email protected]>
Signed-off-by: Tyler Marques <[email protected]>
Signed-off-by: Tyler Marques <[email protected]>
Signed-off-by: Tyler Marques <[email protected]>
|
I've suggested some things in review. Overall I'm pretty ok with this change and the way you structured the info for the nfs use-case. |
|
Thanks a lot for your input @Tylermarques! Appreciate it a lot and thanks @InputObject2 for reviewing :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Sorry about the number of changes, they are mostly just linter / formatter changes. The actual changes completed is the addition of a section explaining how to use a pre-existing and on-network NFS server. I struggled through doing this when moving from my containerized set up to K8s, as all of my media is stored on a NFS.
I did also slightly change the README.md contents, mostly in the form of change the header to a top level header, and others to lower level to comply to
mdldefault settings.Happy to make / discuss any changes. Thanks for putting this together! :)