-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(chart): Added a volume with a toggle for each app #28
feat(chart): Added a volume with a toggle for each app #28
Conversation
Look good to me, I'll run a couple of tests on it and rebuild the new version of the operator if everything is going as expected. Thanks a lot for the effort! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far it looks good to me.
Some changes needed:
- Add a space in each README entries between the first column delimiter and the description
- Add dashes in the if/else/end statements to avoid blank lines in template rendering in *-resources.yml
- Same as before in storage-resources.yml file for those that are missing.
After you do this I will merge it and rebuild the operator :)
Thanks a lot!
02f2881
to
32cd7d1
Compare
Sorry for leaving the PR pending this long, I just sent it and completely forgot about it.
fixed
fixed
I rebased on dc5b9ac and I went through the file and we have all the same sections except the ones I added, but not in the same order? Did you use a linter or something to remake the file? |
32cd7d1
to
52e371e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #26
If the volumes are not specified, the default is to put everything on the current storage (where the media is). Each tool can create a persistentVolumeClaim if it's
volume
field is set.For example to add a config volume for Sonarr: