Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export Version priority parser with Ord impls in kube_core #764

Merged
merged 13 commits into from
Dec 27, 2021
Merged

Export Version priority parser with Ord impls in kube_core #764

merged 13 commits into from
Dec 27, 2021

Commits on Dec 22, 2021

  1. Export Version parser with Ord impl in kube_core 

    doing the cleanup steps described to make this worthy of exporting.
needed for kube-rs/kopium#23

Signed-off-by: clux <[email protected]>
    @clux
    clux committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    f476cb4 View commit details
    Browse the repository at this point in the history

  2. remove leftover TODO + improve doc links between discovery and core 

    Signed-off-by: clux <[email protected]>
    @clux
    clux committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    2626a71 View commit details
    Browse the repository at this point in the history

  3. import more tests, fix one, better docs 

    Signed-off-by: clux <[email protected]>
    @clux
    clux committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    3082efa View commit details
    Browse the repository at this point in the history

  4. a bit less Reverse and less double negatives 

    Signed-off-by: clux <[email protected]>
    @clux
    clux committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    e8061ff View commit details
    Browse the repository at this point in the history

Commits on Dec 24, 2021

  1. Version export - explicitly request ordering (#767) 

    * Explicitly request which ordering to use

Signed-off-by: Teo Klestrup Röijezon <[email protected]>

* Add `Version::latest` that includes considers v2 > v2beta1 > v1

Signed-off-by: Teo Klestrup Röijezon <[email protected]>

* Rename Version::latest_stable to priority

Signed-off-by: Teo Klestrup Röijezon <[email protected]>

* Also rename LatestStable accordingly

Signed-off-by: Teo Klestrup Röijezon <[email protected]>
    @nightkr
    nightkr authored Dec 24, 2021
    Configuration menu
    Copy the full SHA
    770c7be View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into version-export

    @clux
    clux authored Dec 24, 2021
    Configuration menu
    Copy the full SHA
    f69d422 View commit details
    Browse the repository at this point in the history

  3. rename latest to semantic for language consistency 

    we had two orders ::latest and ::priority, but v.latest() was a
ambiguous. v.latest could mean:

- we are sorting by age (but that's not true)
- we are sorting by latest version in semver semantics (true

so think v.semantic() is slightly more clear. v2.semantic() >
v1.semantic() feels a little easier to comprehend than v2.latest() >
v1.latest()

Signed-off-by: clux <[email protected]>
    @clux
    clux committed Dec 24, 2021
    Configuration menu
    Copy the full SHA
    388289b View commit details
    Browse the repository at this point in the history

Commits on Dec 26, 2021

  1. fix self-references and rename semantic to distance 

    Signed-off-by: clux <[email protected]>
    @clux
    clux committed Dec 26, 2021
    Configuration menu
    Copy the full SHA
    9b81b05 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into version-export

    @clux
    clux authored Dec 26, 2021
    Configuration menu
    Copy the full SHA
    3874758 View commit details
    Browse the repository at this point in the history

  3. rename to generation 

    Signed-off-by: clux <[email protected]>
    @clux
    clux committed Dec 26, 2021
    Configuration menu
    Copy the full SHA
    036d028 View commit details
    Browse the repository at this point in the history

  4. We need to split on byte lengths, not code point counts (#772) 

    See #764 (comment)

Signed-off-by: Teo Klestrup Röijezon <[email protected]>
    @nightkr
    nightkr authored Dec 26, 2021
    Configuration menu
    Copy the full SHA
    b5e9a8a View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    Co-authored-by: Teo Klestrup Röijezon <[email protected]>
    @clux @nightkr
    clux and nightkr authored Dec 26, 2021
    Configuration menu
    Copy the full SHA
    1bb9d53 View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2021

  1. Update kube-core/src/version.rs 

    Co-authored-by: kazk <[email protected]>
    @clux @kazk
    clux and kazk authored Dec 27, 2021
    Configuration menu
    Copy the full SHA
    c77e2de View commit details
    Browse the repository at this point in the history