-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to integrate k8s-pb
#1602
Draft
clux
wants to merge
9
commits into
main
Choose a base branch
from
k8s-pb-integrate-indirection
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Try to integrate k8s-pb
#1602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: clux <[email protected]>
starting step towards compilation Signed-off-by: clux <[email protected]>
thankfully straightforward Signed-off-by: clux <[email protected]>
Signed-off-by: clux <[email protected]>
Signed-off-by: clux <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1602 +/- ##
=======================================
- Coverage 75.2% 75.0% -0.1%
=======================================
Files 82 82
Lines 7335 7352 +17
=======================================
Hits 5514 5514
- Misses 1821 1838 +17
|
Signed-off-by: clux <[email protected]>
Signed-off-by: clux <[email protected]>
Signed-off-by: clux <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experiment to see how offensive this actually would look if we were to use an indirection layer (
core::k8s
) and route everything through that and the core traits (Resource
+ResourceExt
).Annoying bits
openapi
vspb
, we can either:pb
oropenapi
), precedence toopenapi
(breaking for --no-default builds)Metadata
is optional in all types ink8s_pb
, but not ink8s-openapi
:Resource
trait to get it to compile - i don't like this eitherResource
trait for ownerreferences/typemeta/labels/annotationsDeserializeOwned
andprost::Message
traits is non-trivialApi
bound to depend on an aliasedDeserTrait
Api
/discovery
modules and anything usingDeserializeOwned
(current)pb
implementations to specifics as we go along?client/mod
for a PoC.Easy bits
k8s-openapi
andk8s-pb
: Names not matchingk8s-openapi
? Likely a bug! k8s-pb#52HashMap
/BTreeMap
usage: Move prost generation from HashMap to BTreeMap k8s-pb#48serde
traits can becfg_attr
d#[cfg(feature...)]
gunk)