-
-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type meta data for list types #1380
Conversation
Signed-off-by: Danil Grigorev <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. Generally looks sensible, just a few nits on tests and an optional suggestion for TypeMeta
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
last nit on naming, new ctors look great and have great docs. ty!
Signed-off-by: Danil Grigorev <[email protected]>
fee5ba3
to
cc20027
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1380 +/- ##
=======================================
- Coverage 72.1% 72.1% -0.0%
=======================================
Files 75 75
Lines 6435 6459 +24
=======================================
+ Hits 4635 4652 +17
- Misses 1800 1807 +7
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for this. Have fixed up the MSRV build so this should be mergeable now.
Motivation
While implementing generic resource listing from discovery results, it seems the type meta is omitted, though it is guarantied to be supplied on the list resource type. This makes it hard to know the resource kind if the ApiCapabilities goes out of scope.
Solution
Store the TypeMeta with the resource list result.