Fix Controller
: pending messages are stuck in the scheduled
map
#1324
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When using the Controller. If some messages are put in the
pending
queue usingpop_queue_message_into_pending
they are not removed from thescheduled
map and will never be.The message in pending will be reconciled later, but all matching messages that follow will not.
Solution
When adding a message to the
pending
queue remove it from thescheduled
map (like it's done inpoll_pop_queue_message
).May fix #1322