Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump base64 to 0.21 #1308

Merged
merged 7 commits into from
Oct 12, 2023
Merged

Bump base64 to 0.21 #1308

merged 7 commits into from
Oct 12, 2023

Conversation

clux
Copy link
Member

@clux clux commented Oct 10, 2023

Final set of breaking dependency bumps for #1181. Followed the base64 migration notes for the deprecated ones, and fixed up the one that used a non-standard config. The import structure is a bit nicer now.

@clux clux mentioned this pull request Oct 10, 2023
6 tasks
@clux clux added dependencies upgrades to dependencies changelog-change changelog change category for prs labels Oct 10, 2023
@clux clux added this to the 0.87.0 milestone Oct 10, 2023
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #1308 (fbf15a3) into main (3d7ebdd) will decrease coverage by 0.0%.
The diff coverage is 80.0%.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1308     +/-   ##
=======================================
- Coverage   72.4%   72.4%   -0.0%     
=======================================
  Files         75      75             
  Lines       6343    6343             
=======================================
- Hits        4587    4586      -1     
- Misses      1756    1757      +1     
Files Coverage Δ
kube-client/src/client/upgrade.rs 81.5% <100.0%> (ø)
kube-client/src/config/file_config.rs 77.6% <100.0%> (ø)
kube-client/src/client/auth/oidc.rs 57.3% <66.7%> (ø)

... and 1 file with indirect coverage changes

@clux clux marked this pull request as ready for review October 10, 2023 20:33
@clux clux requested review from kazk and nightkr October 10, 2023 20:34
kube-client/src/client/auth/oidc.rs Outdated Show resolved Hide resolved
kube-client/src/client/auth/oidc.rs Outdated Show resolved Hide resolved
kube-client/src/client/auth/oidc.rs Outdated Show resolved Hide resolved
Copy link
Member

@nightkr nightkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more nit, but I wouldn't block the PR on that since it's not a new thing :P

kube-client/src/client/auth/oidc.rs Outdated Show resolved Hide resolved
@clux clux merged commit fba2b9d into main Oct 12, 2023
18 checks passed
@clux clux deleted the bump-b64-021 branch October 12, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-change changelog change category for prs dependencies upgrades to dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants