-
-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump base64
to 0.21
#1308
Merged
Merged
Bump base64
to 0.21
#1308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: clux <[email protected]>
Signed-off-by: clux <[email protected]>
clux
added
dependencies
upgrades to dependencies
changelog-change
changelog change category for prs
labels
Oct 10, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1308 +/- ##
=======================================
- Coverage 72.4% 72.4% -0.0%
=======================================
Files 75 75
Lines 6343 6343
=======================================
- Hits 4587 4586 -1
- Misses 1756 1757 +1
|
kazk
approved these changes
Oct 11, 2023
nightkr
reviewed
Oct 12, 2023
Co-authored-by: Natalie <[email protected]> Signed-off-by: Eirik A <[email protected]>
Co-authored-by: Natalie <[email protected]> Signed-off-by: Eirik A <[email protected]>
Signed-off-by: clux <[email protected]>
Signed-off-by: clux <[email protected]>
nightkr
approved these changes
Oct 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more nit, but I wouldn't block the PR on that since it's not a new thing :P
Signed-off-by: clux <[email protected]>
nightkr
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final set of breaking dependency bumps for #1181. Followed the base64 migration notes for the deprecated ones, and fixed up the one that used a non-standard config. The import structure is a bit nicer now.