Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document Controller::reconcile_on and remove Err input requirement #1304

Merged
merged 7 commits into from
Oct 10, 2023
Merged

Document Controller::reconcile_on and remove Err input requirement #1304

merged 7 commits into from
Oct 10, 2023

Commits on Oct 7, 2023

  1. Better docs for Controller::reconcile_on 

    The unstable method currently suggests that this method can be used to help share a store with the reconciler.
This is actually nothing specific to `reconcile_on`, and you can do the same with the streams interface with `watches_stream`.

We made the `reconcile_on` right before `watches_stream` became a thing so this makes sense.

Have reworded the example to highlight that this has a better use-case with actually getting arbitrary third-party info,
and then mapping that to kubernetes objects.

First example that came to mind was using an IntervalStream with tokio and just cycle through a bunch of objects, but there may be a better example that does not pull in the extra dev dep.

Signed-off-by: clux <[email protected]>
    @clux
    clux committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    8022ddf View commit details
    Browse the repository at this point in the history

  2. do the same as on kube.rs 

    Signed-off-by: clux <[email protected]>
    @clux
    clux committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    e86923a View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2023

  1. Merge branch 'main' into reconcile_on_ex

    @clux
    clux authored Oct 9, 2023
    Configuration menu
    Copy the full SHA
    e7c9d25 View commit details
    Browse the repository at this point in the history

  2. Update kube-runtime/src/controller/mod.rs 

    Co-authored-by: David Herberth <[email protected]>
Signed-off-by: Eirik A <[email protected]>
    @clux @Dav1dde
    clux and Dav1dde authored Oct 9, 2023
    Configuration menu
    Copy the full SHA
    0c56911 View commit details
    Browse the repository at this point in the history

  3. use david's suggestion 

    Signed-off-by: clux <[email protected]>
    @clux
    clux committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    22b95c5 View commit details
    Browse the repository at this point in the history

  4. no need for send + static 

    Signed-off-by: clux <[email protected]>
    @clux
    clux committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    f9d3942 View commit details
    Browse the repository at this point in the history

  5. stop pretending to handle errors in reconcile_on 

    Signed-off-by: clux <[email protected]>
    @clux
    clux committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    1a0912b View commit details
    Browse the repository at this point in the history