-
-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the scheduler
message when preponing
#1260
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1260 +/- ##
==========================================
+ Coverage 72.60% 73.28% +0.68%
==========================================
Files 72 75 +3
Lines 5899 6057 +158
==========================================
+ Hits 4283 4439 +156
- Misses 1616 1618 +2
|
In practice this should update the reconciliation reason, fixing kube-rs#1114 Signed-off-by: Natalie Klestrup Röijezon <[email protected]>
nightkr
force-pushed
the
feature/scheduler-update-message
branch
from
July 20, 2023 14:17
51c1b1c
to
f088835
Compare
clux
approved these changes
Jul 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice easy solution hashbrown
is already in dependency tree (via serde_json).
nice tests. minor nit in comments, but don't feel strongly about it.
Signed-off-by: Natalie Klestrup Röijezon <[email protected]>
clux
approved these changes
Jul 20, 2023
clux
changed the title
Update the scheduler message when preponing
Update the Jul 21, 2023
scheduler
message when preponing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In practice this should update the reconciliation reason, fixing #1114. Obsoletes #1241.
Solution
hashbrown::HashMap
lets us update the key, as long as the new value is still considered equivalent to the old one (in terms of bothEq
andHash
). We can't update the version of the value stored in theDelayQueue
, so instead we have to ensure that we resolve it via theHashMap
.