-
-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WatchStreamExt::reflect
to allow chaining on a reflector
#1252
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1252 +/- ##
==========================================
+ Coverage 73.05% 73.19% +0.13%
==========================================
Files 74 75 +1
Lines 5991 6025 +34
==========================================
+ Hits 4377 4410 +33
- Misses 1614 1615 +1
|
Signed-off-by: clux <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some small nits.
Should the kube::runtime::reflector
be removed in favor of this?
Co-authored-by: David Herberth <[email protected]> Signed-off-by: Eirik A <[email protected]>
Signed-off-by: clux <[email protected]>
Signed-off-by: clux <[email protected]>
Appreciate it!
Maybe. I wouldn't want to remove the fn immediately on the introduction here, but if this doesn't have any downsides, then we can probably put a longer lasting deprecation marker on |
Thought this might be nicer than the separate function call now that we allow doing everything on the stream chain. It also makes it clearer to see what parts get reflected (particularly pre or post modify calls) because it follows from the chain order:
NB: I did some rename experiments on this branch but it was a bad idea and force pushed it away. Sorry about the noise.