Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to tower 0.5.0 #1569

Closed
clux opened this issue Sep 6, 2024 · 1 comment · Fixed by #1589
Closed

upgrade to tower 0.5.0 #1569

clux opened this issue Sep 6, 2024 · 1 comment · Fixed by #1589
Labels
dependencies upgrades to dependencies

Comments

@clux
Copy link
Member

clux commented Sep 6, 2024

violently failed ci from dependabot in #1561

not sure if this is going to be hard or not. will have a look on the weekend to see if this worth doing before next release.

tower 0.5.0 changes

@clux clux added this to the 0.94.0 milestone Sep 6, 2024
@clux clux changed the title upgrade to tower-http 0.5.0 upgrade to tower 0.5.0 Sep 6, 2024
@clux
Copy link
Member Author

clux commented Sep 6, 2024

...yeah, this one must wait one release. The tower 0.5.0 release is the first release since march 2022, there are no migration notes, and the PRs referenced are from this whole time period (2.5 years). I expect this one will be fun when it's possible.

Right now it looks impossible without ecosystem propagation. The rustls ecosystem pulls in 0.4.13 and there are type mismatches in errors:

$ cargo tree -i [email protected]
tower v0.5.0
└── kube-client v0.93.1 (/home/clux/kube/kube/kube-client)
    └── kube v0.93.1 (/home/clux/kube/kube/kube)
$ cargo tree -i [email protected]
tower v0.4.13
└── hyper-util v0.1.7
    ├── hyper-rustls v0.27.3
    │   └── kube-client v0.93.1 (/home/clux/kube/kube/kube-client)
    │       └── kube v0.93.1 (/home/clux/kube/kube/kube)
    ├── hyper-timeout v0.5.1
    │   └── kube-client v0.93.1 (/home/clux/kube/kube/kube-client) (*)
    └── kube-client v0.93.1 (/home/clux/kube/kube/kube-client) (*)

Marking as blocked for now.

@clux clux added the blocked awaiting upstream work label Sep 6, 2024
@clux clux removed this from the 0.94.0 milestone Sep 6, 2024
@clux clux added the dependencies upgrades to dependencies label Sep 6, 2024
markdingram added a commit to markdingram/kube-rs that referenced this issue Sep 24, 2024
markdingram added a commit to markdingram/kube-rs that referenced this issue Sep 24, 2024
fixes kube-rs#1569

Signed-off-by: Mark Ingram <[email protected]>
markdingram added a commit to markdingram/kube-rs that referenced this issue Sep 24, 2024
fixes kube-rs#1569

Signed-off-by: Mark Ingram <[email protected]>
markdingram added a commit to markdingram/kube-rs that referenced this issue Sep 24, 2024
fixes kube-rs#1569

Signed-off-by: Mark Ingram <[email protected]>
markdingram added a commit to markdingram/kube-rs that referenced this issue Sep 24, 2024
fixes kube-rs#1569

Signed-off-by: Mark Ingram <[email protected]>
markdingram added a commit to markdingram/kube-rs that referenced this issue Sep 24, 2024
fixes kube-rs#1569

Signed-off-by: Mark Ingram <[email protected]>
@clux clux removed the blocked awaiting upstream work label Sep 24, 2024
@clux clux closed this as completed in bb9a44e Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies upgrades to dependencies
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant