Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP proxy support #1361

Closed
Razz4780 opened this issue Nov 30, 2023 · 2 comments · Fixed by #1496
Closed

HTTP proxy support #1361

Razz4780 opened this issue Nov 30, 2023 · 2 comments · Fixed by #1496
Labels
client http issues with the client

Comments

@Razz4780
Copy link
Contributor

Would you like to work on this feature?

yes

What problem are you trying to solve?

kube-client crate currently supports only SOCKS5 proxies in the kubeconfig (config.proxy_url, HTTP[S]_PROXY/http[s]_proxy env variables). Relevant code starts here. However, proxy can also use the regular HTTP protocol.

Describe the solution you'd like

Inspect scheme of the proxy URI and optionally wrap the base connector with hyper_proxy. Hide it behind a new feature http_proxy (name suggestions welcome).

Found some past discussions on this:
#1010
#837

Describe alternatives you've considered

None so far

Documentation, Adoption, Migration Strategy

No response

Target crate for feature

kube-client

@clux clux added the client http issues with the client label Nov 30, 2023
@clux
Copy link
Member

clux commented Nov 30, 2023

I like the proposal of this in theory because I would also like to support it, but it has one problem practically; the proposed crate has not had a release in over 2 years.

If we were to do this, I would personally prefer to do it after the hyper 1.0 upgrade in #1351 (since we are already having to deal with infrequently updated connector libraries there and this feature would compound that). Waiting for 1.0 would mean getting a 1.0 upgrade pushed up into hyper-proxy first though.

@aviramha
Copy link
Contributor

We have implemented it in our fork, and now that the hyper 1.0 upgrade is done we shall send a PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client http issues with the client
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants