-
-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency upgrades for hyper
and http
1.0
#1351
Comments
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
hyper-timeout 0.5 has been released. |
There's also a small upgrading guide now. |
Yeah I went through it. Still figuring out which |
Yeah, that seemed necessary in the beginning for the connector types to me as well. |
have given up on my current branch for reasons. going to need someone else to helm this because it's above my pain threshold to be useful :( |
In all honesty, it's not the end of the world, so shouldn't be the biggest issue. I'll help you out as soon as I get time, don't worry |
Have updated the root body with more up-to-date information, feel free to post any updates that could help. |
There's a working PR up for this at #1438, so this is likely to get closed soon. |
All the dependabot PRs are failing and are for now being deliberately ignored as they cannot be upgraded alone. Unfortunately, we need to move with the ecosystem on this one, due to how tightly integrated these crates are.
TL;DR: We have to upgrade a slew of crates;
http
,http-body
,hyper
, all the hyper connector libs (hyper-openssl
,hyper-rustls
,hyper-socks2
,hyper-timeout
), all the extraneous hyper libs we need to adopt because of stuff that got moved out,tungstenite
, andtower-http
.http
- with 1.1.0 - we are on 0.2http-body
- with 1.0.0 on crates - we are on 0.4tower-http
- with 0.5.2 - we are on 0.4hyper
- with 1.2.0 - we are on 0.14hyper-openssl
- with 0.10.2hyper-rustls
- with 0.26.0 - we are on 0.24hyper-socks2
- with 0.9.0 nowhyper-timeout
- with 0.5.1 - we are on 0.4tokio-tungstenite
- with 0.21 - we are on 0.20 says no real changesrustls
has also been making sizeable breaking changes to compound the issue, but this thankfully seems not too bad (comparatively) and is hopefully workable from #1418 :rustls
- with 0.23 - we are on 0.21rustls-pemfile
- with 2.1.1 - we are on 1.0and additionally we need to grab some new utility libs spawned out of hyper/http because they didn't want to stabilise any of this:
client::legacy
(i think)It's kind of unclear how to proceed with our
Body
: hyperium/http-body#107..we do have some body extensions of our own, but hopefully that can fall away.
There are also probably legitimate complaints with how we are doing things, but it's a big codebase, and it needs to support a lot. Help is welcome (but this is clearly difficult).
Time Frame
I am not sure this is feasible for us to do until at least reqwest has managed to do it's upgrade. We micic'd a lot of glue code in kube-client and if they can't even upgrade, it's less likely we can. However we could try the backports/deprecated features early perhaps.
Links
The text was updated successfully, but these errors were encountered: