-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refactor, and add possibility for multiple collectors on the same tenant #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me tenant Signed-off-by: Kristof Gyuracz <[email protected]>
kristofgyuracz
force-pushed
the
multiple-collector
branch
from
March 6, 2024 13:20
a65fb55
to
bc8ea1a
Compare
kristofgyuracz
requested review from
OverOrion and
pepov
and removed request for
OverOrion
March 6, 2024 13:58
kristofgyuracz
force-pushed
the
multiple-collector
branch
2 times, most recently
from
March 6, 2024 14:02
d93ac68
to
959e84d
Compare
Signed-off-by: Kristof Gyuracz <[email protected]>
kristofgyuracz
force-pushed
the
multiple-collector
branch
from
March 6, 2024 14:03
959e84d
to
02012da
Compare
Signed-off-by: Kristof Gyuracz <[email protected]>
kristofgyuracz
force-pushed
the
multiple-collector
branch
from
March 6, 2024 15:07
8134c25
to
12326ac
Compare
OverOrion
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, this is a huge advancement 🚀 , overall looks good to me, I only had two minor remarks.
Signed-off-by: Kristof Gyuracz <[email protected]>
kristofgyuracz
force-pushed
the
multiple-collector
branch
from
March 7, 2024 13:04
cf833c4
to
7013688
Compare
pepov
approved these changes
Mar 7, 2024
Signed-off-by: Kristof Gyuracz <[email protected]>
OverOrion
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kristof Gyuracz [email protected]