Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor, and add possibility for multiple collectors on the same tenant #40

Merged
merged 5 commits into from
Mar 7, 2024

Conversation

kristofgyuracz
Copy link
Collaborator

Signed-off-by: Kristof Gyuracz [email protected]

@kristofgyuracz kristofgyuracz marked this pull request as ready for review March 6, 2024 13:58
@kristofgyuracz kristofgyuracz requested review from OverOrion and pepov and removed request for OverOrion March 6, 2024 13:58
@kristofgyuracz kristofgyuracz force-pushed the multiple-collector branch 2 times, most recently from d93ac68 to 959e84d Compare March 6, 2024 14:02
Signed-off-by: Kristof Gyuracz <[email protected]>
Signed-off-by: Kristof Gyuracz <[email protected]>
Copy link
Collaborator

@OverOrion OverOrion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is a huge advancement 🚀 , overall looks good to me, I only had two minor remarks.

internal/controller/telemetry/otel_conf_gen_test.go Outdated Show resolved Hide resolved
internal/controller/telemetry/route_controller.go Outdated Show resolved Hide resolved
Signed-off-by: Kristof Gyuracz <[email protected]>
Signed-off-by: Kristof Gyuracz <[email protected]>
@kristofgyuracz kristofgyuracz merged commit e0a2ee2 into main Mar 7, 2024
12 checks passed
@kristofgyuracz kristofgyuracz deleted the multiple-collector branch March 7, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants