Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support rdkafka2 options #1875

Merged
merged 4 commits into from
Dec 16, 2024
Merged

feat: support rdkafka2 options #1875

merged 4 commits into from
Dec 16, 2024

Conversation

withlin
Copy link
Contributor

@withlin withlin commented Dec 2, 2024

fixes: #1874

@withlin withlin force-pushed the feature/rdkafka_options branch from 3f887e7 to d41e460 Compare December 2, 2024 16:50
@withlin
Copy link
Contributor Author

withlin commented Dec 2, 2024

hi @pepov @csatib02 PTAL, thanks!!!!

@withlin
Copy link
Contributor Author

withlin commented Dec 2, 2024

btw, when release 4.11.2? we need sasl for rdkafka2 options .

@pepov
Copy link
Member

pepov commented Dec 2, 2024

Next release will be 5.0 in two weeks

@withlin
Copy link
Contributor Author

withlin commented Dec 3, 2024 •
edited
Loading

Next release will be 5.0 in two weeks

ok cool, can u help me review?

@csatib02 csatib02 added the enhancement New feature or request label Dec 4, 2024
csatib02
csatib02 reviewed Dec 4, 2024
View reviewed changes
Copy link
Member

@csatib02 csatib02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, some nits and adjustments.

pkg/sdk/logging/model/output/kafka.go Outdated Show resolved Hide resolved
pkg/sdk/logging/model/output/kafka.go Show resolved Hide resolved
pkg/sdk/logging/model/output/kafka.go Outdated Show resolved Hide resolved
pkg/sdk/logging/model/output/kafka.go Outdated Show resolved Hide resolved
pkg/sdk/logging/model/output/kafka.go Outdated Show resolved Hide resolved
pkg/sdk/logging/model/output/kafka_test.go Show resolved Hide resolved
@withlin
Copy link
Contributor Author

withlin commented Dec 4, 2024

@csatib02 done. plz review again. thanks

@withlin withlin requested a review from csatib02 December 4, 2024 11:38
@withlin withlin force-pushed the feature/rdkafka_options branch from 0a4c776 to 76a67ce Compare December 9, 2024 13:12
@withlin
Copy link
Contributor Author

withlin commented Dec 9, 2024

hi @pepov @csatib02 can u review again ?

@withlin withlin requested a review from pepov December 10, 2024 09:40
withlin and others added 4 commits December 16, 2024 17:10
@withlin @pepov
feat: support rdkafka2 options
c6a154d 
Signed-off-by: withlin <[email protected]>
@withlin @pepov
fix: some nits
77aa696 
Signed-off-by: withlin <[email protected]>

Signed-off-by: withlin <[email protected]>
@withlin @pepov
fix: missing markdown
766970f 
Signed-off-by: withlin <[email protected]>

Signed-off-by: withlin <[email protected]>
@pepov
chore: fix rdkafka options tests
ca91c14 
Signed-off-by: Peter Wilcsinszky <[email protected]>
@pepov pepov force-pushed the feature/rdkafka_options branch from 76a67ce to ca91c14 Compare December 16, 2024 16:10
@pepov pepov merged commit f3eca81 into kube-logging:master Dec 16, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csatib02 csatib02 csatib02 approved these changes

@OverOrion OverOrion OverOrion approved these changes

@pepov pepov pepov approved these changes

Assignees

@withlin withlin

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support rdkafka_options in rdkafka2
4 participants
@withlin @pepov @OverOrion @csatib02