Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add pre-delete-hook #1872

Closed
wants to merge 1 commit into from
Closed

feat: add pre-delete-hook #1872

wants to merge 1 commit into from

Conversation

csatib02
Copy link
Member

Fixes: #1859

@csatib02
feat: add pre-delete-hook
1399f11 
Signed-off-by: Bence Csati <[email protected]>
@csatib02 csatib02 added the enhancement New feature or request label Nov 29, 2024
@csatib02 csatib02 requested review from pepov and OverOrion November 29, 2024 16:05
@csatib02 csatib02 self-assigned this Nov 29, 2024
aslafy-z
aslafy-z reviewed Nov 29, 2024
View reviewed changes
charts/logging-operator/templates/pre-delete-hook.yaml
@@ -0,0 +1,60 @@
apiVersion: batch/v1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this job should be opt in:

  • uninstall does not mean delete every CRs
  • argocd does not support pre-delete hook

@csatib02 csatib02 closed this Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aslafy-z aslafy-z aslafy-z left review comments

@pepov pepov Awaiting requested review from pepov

@OverOrion OverOrion Awaiting requested review from OverOrion

Assignees

@csatib02 csatib02

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove resource finalizers before terminating operator
2 participants
@csatib02 @aslafy-z