Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to add strategy and topologySpreadConstraints to the operator #1840

Merged
merged 4 commits into from
Nov 5, 2024

Conversation

karloramone
Copy link
Contributor

If you have two datacenters and you would like to deploy two replicas of the operator in each, you can't do that cause there is no possibility to modify topologySpreadConstraints of the operator deployment. The only way to assure two pods running in each datacenters is to run three replicas with the podAntiAffinity.

If you have a three node cluster you are not able to run three replicas with podAntiAffinity on the hostname topology key.
The problem is in the default strategy is configured to add the fourth replica before removing the old one. Because of the mentioned configuration above this is not possible and pod stays in pending state.

This fixes those two examples.
There is also one typo on the README.md that I noticed and fixed.

Copy link
Member

@csatib02 csatib02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Please run make generate so the CI can pass.

@karloramone
Copy link
Contributor Author

Thanks @csatib02, I did it.
However, two jobs failed.
vulndb would probably fixed with the re-run and for the E2E tests I'm not sure.
Can you re-run the pipeline?

@csatib02 csatib02 merged commit 1f0a20f into kube-logging:master Nov 5, 2024
17 checks passed
@karloramone karloramone deleted the operator-deployment-chart branch November 5, 2024 09:59
@csatib02 csatib02 added the enhancement New feature or request label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants