Add support for VMware Log Intelligence #1685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zrobisho
commented
Mar 1, 2024
zrobisho
commented
- Add support for VMware Log Intelligence fluentd plugin https://github.com/vmware/fluent-plugin-vmware-log-intelligence
zrobisho
force-pushed
the
vmware-log-intelligence-output
branch
from
8d1e0b3 to
ff1df5a
Compare
pepov
requested changes
Mar 2, 2024
zrobisho
force-pushed
the
vmware-log-intelligence-output
branch
from
4e0836f to
c9da2ce
Compare
|
@pepov I've addressed the comments, please lmk if there is anything else you'd like me to look at. Thanks for the review! |
zrobisho
force-pushed
the
vmware-log-intelligence-output
branch
2 times, most recently
from
c3974fa to
6b05230
Compare
pepov
approved these changes
Mar 4, 2024
|
Hey @zrobisho, Thank you for your PR, could you rebase it against the latest master? I think running |
- Add support for VMware Log Intelligence fluentd plugin https://github.com/vmware/fluent-plugin-vmware-log-intelligence Signed-off-by: Zachary Robichaud <[email protected]>
zrobisho
force-pushed
the
vmware-log-intelligence-output
branch
2 times, most recently
from
94c85d2 to
41ad2aa
Compare
- Fix indentation for example - Update type of verify_ssl to allow user ability to disable Signed-off-by: Zachary Robichaud <[email protected]>
zrobisho
force-pushed
the
vmware-log-intelligence-output
branch
from
41ad2aa to
d2f2b1f
Compare
|
@OverOrion Rebased |
OverOrion
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.