-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable using custom PVC without a template for the statefulset (for the buffer volume and also as extravolumes) #1617
Conversation
9f6e53c
to
370e7af
Compare
ebd0e32
to
9d8df85
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I spotted a couple of typos, can you please fix them?
Also, can you please update the PR name so it reflects the changes and add fixes #1616
in the PR description?
You will also have to sign your commits, see https://github.com/kube-logging/logging-operator/pull/1617/checks?check_run_id=20378816523.
I promised to look into how we could make the comparison more efficient, sorry I haven't been able to get back to that |
Hi @pepov and @aslafy-z , |
@bbyreddy we want to keep this instead of introducing yet another huge field to the fluentd spec |
I'm planning to add some technical docs as well |
Signed-off-by: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> Signed-off-by: Bhaskar Reddy Byreddy <bbyreddy@softwareag.com>
Signed-off-by: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> Signed-off-by: Bhaskar Reddy Byreddy <bbyreddy@softwareag.com>
…cified in the fluentd.extraVolumes.volume.pvc.source.claimName of the fluentd definition are honoured, instead of always attempting to create a new PVC. Signed-off-by: Bhaskar Reddy Byreddy <bbyreddy@softwareag.com>
Signed-off-by: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com>
Signed-off-by: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> Signed-off-by: Bhaskar Reddy Byreddy <bbyreddy@softwareag.com>
…cified in the fluentd.extraVolumes.volume.pvc.source.claimName of the fluentd definition are honoured, instead of always attempting to create a new PVC. Signed-off-by: Bhaskar Reddy Byreddy <bbyreddy@softwareag.com>
…ails specified in the fluentd.extraVolumes.volume.pvc.source.claimName of the fluentd definition are honoured, instead of always attempting to create a new PVC." This reverts commit 981d4b4. Signed-off-by: Bhaskar Reddy Byreddy <bbyreddy@softwareag.com>
…cified in the fluentd.extraVolumes.volume.pvc.source.claimName of the fluentd definition are honoured, instead of always attempting to create a new PVC. Signed-off-by: Bhaskar Reddy Byreddy <bbyreddy@softwareag.com>
…cified in the fluentd.extraVolumes.volume.pvc.source.claimName of the fluentd definition are honoured, instead of always attempting to create a new PVC. Signed-off-by: Bhaskar Reddy Byreddy <bbyreddy@softwareag.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Bhaskar Reddy Byreddy <bbyreddy@softwareag.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Bhaskar Reddy Byreddy <bbyreddy@softwareag.com>
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.16.0 to 0.17.0. - [Commits](golang/crypto@v0.16.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Szilard Parrag <szilard.parrag@axoflow.com> Signed-off-by: Bhaskar Reddy Byreddy <bbyreddy@softwareag.com>
Signed-off-by: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> Signed-off-by: Bhaskar Reddy Byreddy <bbyreddy@softwareag.com>
Signed-off-by: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> Signed-off-by: Bhaskar Reddy Byreddy <bbyreddy@softwareag.com>
Signed-off-by: Kristof Gyuracz <kristof.gyuracz@gmail.com> Signed-off-by: Bhaskar Reddy Byreddy <bbyreddy@softwareag.com>
close kube-logging#1633 Signed-off-by: cmontemuino <1761056+cmontemuino@users.noreply.github.com> Signed-off-by: Bhaskar Reddy Byreddy <bbyreddy@softwareag.com>
…ables. Signed-off-by: Bhaskar Reddy Byreddy <bbyreddy@softwareag.com>
Signed-off-by: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> Signed-off-by: Bhaskar Reddy Byreddy <bbyreddy@softwareag.com>
Signed-off-by: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> Signed-off-by: Bhaskar Reddy Byreddy <bbyreddy@softwareag.com>
57635ed
to
b9819d8
Compare
…traVolumes-in-the-fluentd-definition-is-not-honoured
…traVolumes-in-the-fluentd-definition-is-not-honoured Signed-off-by: Bhaskar Reddy Byreddy <bbyreddy@softwareag.com>
@bbyreddy can you check if the solution that works for you? |
@aslafy-z , you may have to mark this as resolved and approve the PR as the code has changed now and doesn't have the typos anymore. Thanks! |
@aslafy-z typos has been fixed and signoff done, I'm merging this |
…he buffer volume and also as extravolumes) (#1617) Signed-off-by: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> Signed-off-by: Bhaskar Reddy Byreddy <bbyreddy@softwareag.com> Co-authored-by: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com>
Enable using custom PVC without a template for the statefulset (for the buffer volume and also as extravolumes) (#1617)
commit f9c64d9 Author: Fred <frederic.pege@gmail.com> Date: Thu Feb 15 11:31:02 2024 +0100 chore: fmt commit 649b7a2 Merge: 3aed11e 707b7c0 Author: Frédéric Pégé <frederic.pege@gmail.com> Date: Thu Feb 15 11:27:41 2024 +0100 Merge branch 'master' into patch-1 commit 707b7c0 Merge: 3738d7b 9a801b5 Author: Szilard Parrag <szilard.parrag@gmail.com> Date: Thu Feb 8 10:27:56 2024 +0100 Merge pull request kube-logging#1602 from yunkunrao/feat-pdb Feat: add PodDisruptionBudget for fluentd commit 9a801b5 Author: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> Date: Thu Feb 8 09:54:27 2024 +0100 fix invalid reference on fluentdspec Signed-off-by: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> commit 85d0ac4 Author: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> Date: Wed Feb 7 17:48:03 2024 +0100 ignore go.work.sum instead of go.work* Signed-off-by: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> commit 8dc01d3 Merge: fff8120 3738d7b Author: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> Date: Wed Feb 7 17:34:19 2024 +0100 Merge remote-tracking branch 'origin/master' into feat-pdb commit fff8120 Author: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> Date: Wed Feb 7 17:33:08 2024 +0100 add missing constant Signed-off-by: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> commit 3738d7b Merge: 133eff3 b2f6253 Author: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> Date: Wed Feb 7 17:17:01 2024 +0100 Merge pull request kube-logging#1664 from kube-logging/release-4.5 Merge latest updates from release 4.5 back to master commit b2f6253 Merge: bbb877a 82a74a8 Author: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> Date: Wed Feb 7 17:03:40 2024 +0100 Merge pull request kube-logging#1663 from helio/release-4.5-fix-parsers-conf-location fix: default parsers conf location wrong on windows commit 11e426b Merge: c39cbc0 133eff3 Author: raoyunkun <raoyunkun@cestc.cn> Date: Tue Feb 6 18:52:03 2024 +0800 Merge branch 'master' into feat-pdb commit 82a74a8 Author: Michael Weibel <michael@helio.exchange> Date: Tue Jan 30 13:58:03 2024 +0100 fix: default parsers conf location wrong on windows both linux and windows have it at the same location Signed-off-by: Michael Weibel <michael@helio.exchange> commit bbb877a Merge: 34c83ba ad77b62 Author: Szilard Parrag <szilard.parrag@gmail.com> Date: Mon Feb 5 16:42:01 2024 +0100 Merge pull request kube-logging#1661 from kube-logging/fix-tenant-aggregator-detection fix tenant aggregation detection commit ad77b62 Author: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> Date: Sun Feb 4 18:38:03 2024 +0100 fix tenant aggregation detection Signed-off-by: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> commit 133eff3 Merge: 068f24f 4776648 Author: Szilard Parrag <szilard.parrag@gmail.com> Date: Wed Jan 31 08:07:49 2024 +0100 Merge pull request kube-logging#1656 from helio/fix-parsers-conf-location fix: default parsers conf location wrong on windows commit 068f24f Merge: e87e3e2 a3b1dd8 Author: Szilard Parrag <szilard.parrag@gmail.com> Date: Tue Jan 30 15:08:31 2024 +0100 Merge pull request kube-logging#1655 from kube-logging/loki-link-fix doc: loki.go axosyslog link fix commit a3b1dd8 Author: Robert Fekete <fekete77.robert@gmail.com> Date: Mon Jan 29 21:45:02 2024 +0100 doc: loki.go axosyslog link fix Co-authored-by: Robert Fekete <fekete77.robert@gmail.com Signed-off-by: Szilard Parrag <szilard.parrag@axoflow.com> commit 4776648 Author: Michael Weibel <michael@helio.exchange> Date: Tue Jan 30 13:58:03 2024 +0100 fix: default parsers conf location wrong on windows both linux and windows have it at the same location Signed-off-by: Michael Weibel <michael@helio.exchange> commit 34c83ba Merge: ccb3f58 cb68418 Author: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> Date: Mon Jan 29 15:12:10 2024 +0100 Merge pull request kube-logging#1653 from kube-logging/backport-pvc-fix Enable using custom PVC without a template for the statefulset (for the buffer volume and also as extravolumes) (kube-logging#1617) commit cb68418 Author: Bhaskar Reddy Byreddy <bbyreddy@softwareag.com> Date: Tue Jan 16 12:28:40 2024 +0000 Enable using custom PVC without a template for the statefulset (for the buffer volume and also as extravolumes) (kube-logging#1617) Signed-off-by: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> Signed-off-by: Bhaskar Reddy Byreddy <bbyreddy@softwareag.com> Co-authored-by: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> commit e87e3e2 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Fri Jan 26 09:01:28 2024 +0100 fix(deps): update all dependencies (kube-logging#1651) Signed-off-by: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> commit 3b041ef Merge: 61e26f6 dda3cf0 Author: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> Date: Wed Jan 24 16:06:56 2024 +0100 Merge pull request kube-logging#1414 from kube-logging/aslafy-z-patch-7 feat: fluentbit hotreload commit dda3cf0 Author: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> Date: Wed Jan 24 15:54:37 2024 +0100 chore: docs for fluentbit reload Signed-off-by: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> commit 61e26f6 Merge: 273a845 17bd8ce Author: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> Date: Wed Jan 24 15:03:34 2024 +0100 Merge pull request kube-logging#1649 from kube-logging/dep-up chore: upgrade protobuf dep commit 17bd8ce Author: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> Date: Wed Jan 24 14:43:23 2024 +0100 chore: upgrade protobuf dep Signed-off-by: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> commit 596a801 Author: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> Date: Wed Jan 24 14:38:57 2024 +0100 test: extend test case to check the fluentbit hotreload capability more precisely, apply some refactors for code reuse Signed-off-by: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> commit 273a845 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Wed Jan 24 13:43:47 2024 +0100 chore(deps): update all dependencies (kube-logging#1627) Signed-off-by: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> commit 02849a8 Author: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> Date: Wed Jan 24 12:35:07 2024 +0100 fix license Signed-off-by: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> commit 90441a6 Author: Zadkiel Aharonian <hello@zadkiel.fr> Date: Wed Aug 2 12:40:04 2023 +0200 feat: fluentbit hotreload Signed-off-by: Zadkiel Aharonian <hello@zadkiel.fr> commit 5150a63 Merge: 3852894 5fb63b6 Author: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> Date: Mon Jan 22 14:49:17 2024 +0100 Merge pull request kube-logging#1648 from kube-logging/merge-release-4.5 merge release 4.5 commit 5fb63b6 Merge: ccb3f58 3852894 Author: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> Date: Mon Jan 22 14:03:21 2024 +0100 Merge remote-tracking branch 'origin/master' into merge-release-4.5 Signed-off-by: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> commit ccb3f58 Merge: 68f0e88 a925fc6 Author: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> Date: Fri Jan 19 16:38:06 2024 +0100 Merge pull request kube-logging#1646 from kube-logging/aggregator-config-fix fix: add namespace filter when listing aggregator configs (kube-logging#1644) commit a925fc6 Author: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> Date: Fri Jan 19 16:24:42 2024 +0100 fix: add namespace filter when listing aggregator configs (kube-logging#1644) Signed-off-by: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> commit 68f0e88 Merge: ec3f380 9a8e948 Author: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> Date: Fri Jan 19 16:25:06 2024 +0100 Merge pull request kube-logging#1643 from kube-logging/fix-openobserve-port-arg fix(syslog-ng): add port to OpenObserve output commit 3852894 Author: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> Date: Fri Jan 19 16:24:42 2024 +0100 fix: add namespace filter when listing aggregator configs (kube-logging#1644) Signed-off-by: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> commit 9a8e948 Author: Szilard Parrag <szilard.parrag@axoflow.com> Date: Fri Jan 19 11:06:21 2024 +0100 docs(OpenObserve): fix capitalization Signed-off-by: Szilard Parrag <szilard.parrag@axoflow.com> commit 3e57fe4 Author: Szilard Parrag <szilard.parrag@axoflow.com> Date: Fri Jan 19 10:49:08 2024 +0100 fix(syslog-ng): add port to OpenObserve output Signed-off-by: Szilard Parrag <szilard.parrag@axoflow.com> commit f10d696 Author: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> Date: Thu Jan 18 19:58:03 2024 +0100 config type move (kube-logging#1641) Signed-off-by: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> commit c39cbc0 Author: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> Date: Tue Jan 16 15:30:33 2024 +0100 chore: run make check-diff Signed-off-by: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> commit db2ff29 Author: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> Date: Tue Jan 16 15:09:03 2024 +0100 chore: remove unnecessary deepcopy, since we are only referencing pdb values Signed-off-by: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> commit 3f0438d Author: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> Date: Tue Jan 16 15:05:42 2024 +0100 fix: adapt to changed method signature Signed-off-by: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> commit e683595 Merge: 07940ce 12220f1 Author: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> Date: Tue Jan 16 14:59:58 2024 +0100 Merge remote-tracking branch 'origin/master' into feat-pdb Signed-off-by: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> commit 12220f1 Author: Robert Fekete <fekete77.robert@gmail.com> Date: Tue Jan 16 14:56:22 2024 +0100 Generated doc fixes 4.5 (kube-logging#1619) Signed-off-by: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> Signed-off-by: Robert Fekete <fekete77.robert@gmail.com> Co-authored-by: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> commit fc1658a Author: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> Date: Tue Jan 16 13:29:38 2024 +0100 Fix loggingroute notifications for changes in the logging resource status (kube-logging#1640) Signed-off-by: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> commit f48071a Author: Bhaskar Reddy Byreddy <bbyreddy@softwareag.com> Date: Tue Jan 16 12:28:40 2024 +0000 Enable using custom PVC without a template for the statefulset (for the buffer volume and also as extravolumes) (kube-logging#1617) Signed-off-by: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> Signed-off-by: Bhaskar Reddy Byreddy <bbyreddy@softwareag.com> Co-authored-by: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> commit 38f6f1c Merge: 626812c 28b6bef Author: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> Date: Fri Jan 12 10:40:47 2024 +0100 Merge pull request kube-logging#1639 from kube-logging/plugin-doc-fix fix doc link for enhance-k8s-metadata plugin commit 28b6bef Author: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> Date: Thu Jan 11 09:57:22 2024 +0100 fix doc link for enhance-k8s-metadata plugin Signed-off-by: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> commit ec3f380 Merge: 2c4ff95 ef62afa Author: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> Date: Mon Jan 8 18:38:57 2024 +0100 Merge pull request kube-logging#1636 from kube-logging/loki-grpc-tls-options fix(syslog-ng-loki-output): fix invalid tls options commit ef62afa Author: Kristof Gyuracz <kristof.gyuracz@gmail.com> Date: Mon Jan 8 14:37:08 2024 +0100 fix(syslog-ng-loki-output): fix invalid tls options Signed-off-by: Kristof Gyuracz <kristof.gyuracz@gmail.com> commit 626812c Merge: a866a85 54e4d7b Author: Peter Wilcsinszky <peter.wilcsinszky@axoflow.com> Date: Mon Jan 8 17:33:41 2024 +0100 Merge pull request kube-logging#1633 from cmontemuino/check-prometheus-capabilities chore(chart): check CRDs available before installing ServiceMonitor commit a866a85 Merge: 2d00cd3 7bf8c3d Author: Kristóf Gyurácz <4431202+kristofgyuracz@users.noreply.github.com> Date: Mon Jan 8 15:16:12 2024 +0100 Merge pull request kube-logging#1634 from kube-logging/grpc-tls-options fix(syslog-ng-loki-output): fix invalid tls options commit 7bf8c3d Author: Kristof Gyuracz <kristof.gyuracz@gmail.com> Date: Mon Jan 8 14:37:08 2024 +0100 fix(syslog-ng-loki-output): fix invalid tls options Signed-off-by: Kristof Gyuracz <kristof.gyuracz@gmail.com> commit 54e4d7b Author: cmontemuino <1761056+cmontemuino@users.noreply.github.com> Date: Mon Jan 8 10:06:56 2024 +0100 chore(chart): check CRDs available before installing ServiceMonitor close kube-logging#1633 Signed-off-by: cmontemuino <1761056+cmontemuino@users.noreply.github.com> commit 3aed11e Author: Fred <frederic_pege@ext.carrefour.com> Date: Fri Jan 5 10:58:57 2024 +0100 fix: missing curly bracket commit d648357 Author: Frédéric Pégé <frederic.pege@gmail.com> Date: Fri Jan 5 10:38:21 2024 +0100 Expose metrics port of Event Tailer Signed-off-by: Frédéric Pégé <frederic.pege@gmail.com> commit 07940ce Author: raoyunkun <raoyunkun@cestc.cn> Date: Sun Dec 31 11:25:00 2023 +0800 Resolve conflicts Signed-off-by: raoyunkun <raoyunkun@cestc.cn> commit b51f357 Author: raoyunkun <raoyunkun@cestc.cn> Date: Tue Dec 19 17:01:53 2023 +0800 refactor Signed-off-by: raoyunkun <raoyunkun@cestc.cn> commit 06e6149 Author: yunkunrao <yunkunrao@gmail.com> Date: Sun Nov 26 22:51:18 2023 +0800 feat: add PodDisruptionBudget for fluentd Signed-off-by: raoyunkun <raoyunkun@cestc.cn>
Ensured that the custom PVC source details specified in the fluentd.extraVolumes.volume.pvc.source.claimName of the fluentd definition are honoured instead of always attempting to create a new PVC.
Introduced empty checks to the PersistentVolumeClaim.PersistentVolumeClaimSpec and PersistentVolumeClaim.PersistentVolumeSource structures and ApplyPVCForStatefulSet() and ApplyVolumeForPodSpec() functions are invoked only when the respective structures are not empty.