feat(helm-chart): seperate CRDs into subchart #1606
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know about the e2e-tests and docs but I would assume there would be some changes needed. Can you please help me with this. |
sebastiangaiser
force-pushed
the
feature/improve-crd-handling-via-subchart
branch
2 times, most recently
from
61bee0b to
43214c8
Compare
Signed-off-by: Sebastian Gaiser <[email protected]>
sebastiangaiser
force-pushed
the
feature/improve-crd-handling-via-subchart
branch
from
43214c8 to
ee5654f
Compare
|
@pepov (I think it was you triggering the checks) I might need some help for the e2e tests. Can you please assist me a bit. |
|
@sebastiangaiser can you please join the project discord? https://discord.gg/JuacJgWA7K |
|
closing this in favor of a trivial solution for now to avoid the complexity of breaking out the subchart: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR seperates the CRDs into their own helm-chart, since this has some benefits according to the official helm documentation.
https://helm.sh/docs/chart_best_practices/custom_resource_definitions/#some-caveats-and-explanations
Method 2 describes to have CRDs in their own helm-chart, which works around the problems described in Method 1 - which this chart currently uses.
I took the inspiration from https://github.com/metallb/metallb/tree/main/charts/metallb, where they also have a seperate chart for CRDs, which saved us some trouble in the past already.