Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix metricRelabelings templating in helm chart #1560

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Fix metricRelabelings templating in helm chart #1560

merged 1 commit into from
Oct 30, 2023

Conversation

gdziwoki
Copy link
Contributor

@gdziwoki gdziwoki commented Oct 27, 2023 •
edited
Loading

Fixes #1559

@gdziwoki gdziwoki marked this pull request as ready for review October 27, 2023 07:44
@OverOrion
Copy link
Contributor

Thank you for your contribution @gdziwoki! The CI requires that every contributor signs their commits using the --signoff flag. Could you please add it?

@gdziwoki
Copy link
Contributor Author

Done!

aslafy-z
aslafy-z approved these changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@aslafy-z aslafy-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@aslafy-z aslafy-z merged commit 0b12af3 into kube-logging:master Oct 30, 2023
15 checks passed
@pepov pepov added the bugfix label Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aslafy-z aslafy-z aslafy-z approved these changes

@pepov pepov pepov approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

metricRelabelings typo in HelmChart
4 participants
@gdziwoki @OverOrion @pepov @aslafy-z