Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecation notice for non-unique loggingRef #1391

Merged
merged 5 commits into from
Jul 26, 2023
Merged

Conversation

pepov
Copy link
Member

@pepov pepov commented Jul 24, 2023

Fixes #1386

Signed-off-by: Peter Wilcsinszky [email protected]

controllers/logging/logging_controller.go Outdated Show resolved Hide resolved
controllers/logging/logging_controller.go Outdated Show resolved Hide resolved
@pepov pepov requested a review from siliconbrain July 26, 2023 13:03
@pepov pepov changed the title fix: refuse to reconcile logging with non-unique loggingRef chore: deprecation notice for non-unique loggingRef Jul 26, 2023
…e logging resource validation logic to the ValidationReconciler

Signed-off-by: Peter Wilcsinszky <[email protected]>
Signed-off-by: Peter Wilcsinszky <[email protected]>
pkg/resources/model/resources.go Outdated Show resolved Hide resolved
pkg/resources/model/repository.go Outdated Show resolved Hide resolved
@pepov pepov merged commit c92e7c1 into master Jul 26, 2023
@pepov pepov deleted the loggingref-check branch July 26, 2023 20:33
eumel8 pushed a commit to eumel8/logging-operator that referenced this pull request Jul 31, 2023
add notice to logging status when there are multiple logging resources with the same ref

Signed-off-by: Peter Wilcsinszky <[email protected]>
Signed-off-by: Frank Kloeker <[email protected]>
nak0f pushed a commit to nak0f/logging-operator that referenced this pull request Nov 22, 2023
add notice to logging status when there are multiple logging resources with the same ref

Signed-off-by: Peter Wilcsinszky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refuse to reconcile multiple logging resources with the same loggingRef
3 participants