-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: deprecation notice for non-unique loggingRef #1391
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siliconbrain
approved these changes
Jul 25, 2023
pepov
changed the title
fix: refuse to reconcile logging with non-unique loggingRef
chore: deprecation notice for non-unique loggingRef
Jul 26, 2023
aslafy-z
reviewed
Jul 26, 2023
Signed-off-by: Peter Wilcsinszky <[email protected]>
…e logging resource validation logic to the ValidationReconciler Signed-off-by: Peter Wilcsinszky <[email protected]>
Signed-off-by: Peter Wilcsinszky <[email protected]>
Signed-off-by: Peter Wilcsinszky <[email protected]>
siliconbrain
approved these changes
Jul 26, 2023
Signed-off-by: Peter Wilcsinszky <[email protected]>
eumel8
pushed a commit
to eumel8/logging-operator
that referenced
this pull request
Jul 31, 2023
add notice to logging status when there are multiple logging resources with the same ref Signed-off-by: Peter Wilcsinszky <[email protected]> Signed-off-by: Frank Kloeker <[email protected]>
nak0f
pushed a commit
to nak0f/logging-operator
that referenced
this pull request
Nov 22, 2023
add notice to logging status when there are multiple logging resources with the same ref Signed-off-by: Peter Wilcsinszky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1386
Signed-off-by: Peter Wilcsinszky [email protected]