Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix append slice #1383

Merged
merged 1 commit into from
Jul 20, 2023
Merged

fix append slice #1383

merged 1 commit into from
Jul 20, 2023

Conversation

eumel8
Copy link
Collaborator

@eumel8 eumel8 commented Jul 19, 2023 •
edited
Loading

If prometheus crd are available, resourceObjects get lost for reconciling. In effect no Statefulset for fluentd will created.

solved: #1384

@eumel8
fix append slice
6da6668 
Signed-off-by: Frank Kloeker <[email protected]>
@pepov pepov enabled auto-merge July 20, 2023 07:06
@pepov pepov disabled auto-merge July 20, 2023 07:06
@pepov pepov self-requested a review July 20, 2023 07:06
@pepov pepov requested review from ahma and tarokkk July 20, 2023 07:12
ahma
ahma approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@ahma ahma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @eumel8 LGTM

@pepov pepov merged commit 66ab351 into kube-logging:master Jul 20, 2023
@aslafy-z aslafy-z mentioned this pull request Jul 20, 2023
Closed
@eumel8 eumel8 deleted the fix/reconciling branch July 21, 2023 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahma ahma ahma approved these changes

@pepov pepov pepov approved these changes

@tarokkk tarokkk Awaiting requested review from tarokkk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eumel8 @pepov @ahma