feat: make control namespace field immutable

Signed-off-by: Bence Csati <[email protected]>
kube-logging · Dec 6, 2024 · ddc21ce · ddc21ce
1 parent 9a91a03
commit ddc21ce
Show file tree

Hide file tree

Showing 8 changed files with 24 additions and 1 deletion.
diff --git a/...harts/logging-operator-crds/templates/logging-extensions.banzaicloud.io_eventtailers.yaml b/...harts/logging-operator-crds/templates/logging-extensions.banzaicloud.io_eventtailers.yaml
@@ -333,6 +333,9 @@ spec:
                 type: object
               controlNamespace:
                 type: string
+                x-kubernetes-validations:
+                - message: Value is immutable, please recreate the resource
+                  rule: self == oldSelf
               image:
                 properties:
                   imagePullSecrets:

diff --git a/...ging-operator/charts/logging-operator-crds/templates/logging.banzaicloud.io_loggings.yaml b/...ging-operator/charts/logging-operator-crds/templates/logging.banzaicloud.io_loggings.yaml
@@ -84,6 +84,9 @@ spec:
                 type: object
               controlNamespace:
                 type: string
+                x-kubernetes-validations:
+                - message: Value is immutable, please recreate the resource
+                  rule: self == oldSelf
               defaultFlow:
                 properties:
                   filters:

diff --git a/charts/logging-operator/crds/logging-extensions.banzaicloud.io_eventtailers.yaml b/charts/logging-operator/crds/logging-extensions.banzaicloud.io_eventtailers.yaml
@@ -330,6 +330,9 @@ spec:
                 type: object
               controlNamespace:
                 type: string
+                x-kubernetes-validations:
+                - message: Value is immutable, please recreate the resource
+                  rule: self == oldSelf
               image:
                 properties:
                   imagePullSecrets:

diff --git a/charts/logging-operator/crds/logging.banzaicloud.io_loggings.yaml b/charts/logging-operator/crds/logging.banzaicloud.io_loggings.yaml
@@ -81,6 +81,9 @@ spec:
                 type: object
               controlNamespace:
                 type: string
+                x-kubernetes-validations:
+                - message: Value is immutable, please recreate the resource
+                  rule: self == oldSelf
               defaultFlow:
                 properties:
                   filters:

diff --git a/config/crd/bases/logging-extensions.banzaicloud.io_eventtailers.yaml b/config/crd/bases/logging-extensions.banzaicloud.io_eventtailers.yaml
@@ -330,6 +330,9 @@ spec:
                 type: object
               controlNamespace:
                 type: string
+                x-kubernetes-validations:
+                - message: Value is immutable, please recreate the resource
+                  rule: self == oldSelf
               image:
                 properties:
                   imagePullSecrets:

diff --git a/config/crd/bases/logging.banzaicloud.io_loggings.yaml b/config/crd/bases/logging.banzaicloud.io_loggings.yaml
@@ -81,6 +81,9 @@ spec:
                 type: object
               controlNamespace:
                 type: string
+                x-kubernetes-validations:
+                - message: Value is immutable, please recreate the resource
+                  rule: self == oldSelf
               defaultFlow:
                 properties:
                   filters:

diff --git a/pkg/sdk/extensions/api/v1alpha1/eventtailer_types.go b/pkg/sdk/extensions/api/v1alpha1/eventtailer_types.go
@@ -35,7 +35,8 @@ type _metaEventTailer = interface{} //nolint:deadcode,unused
 
 // EventTailerSpec defines the desired state of EventTailer
 type EventTailerSpec struct {
-	//+kubebuilder:validation:Required
+	// +kubebuilder:validation:Required
+	// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="Value is immutable, please recreate the resource"
 
 	// The resources of EventTailer will be placed into this namespace
 	ControlNamespace string `json:"controlNamespace"`

diff --git a/pkg/sdk/logging/api/v1beta1/logging_types.go b/pkg/sdk/logging/api/v1beta1/logging_types.go
@@ -72,6 +72,10 @@ type LoggingSpec struct {
 	WatchNamespaceSelector *metav1.LabelSelector `json:"watchNamespaceSelector,omitempty"`
 	// Cluster domain name to be used when templating URLs to services (default: "cluster.local.").
 	ClusterDomain *string `json:"clusterDomain,omitempty"`
+
+	// +kubebuilder:validation:Required
+	// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="Value is immutable, please recreate the resource"
+
 	// Namespace for cluster wide configuration resources like ClusterFlow and ClusterOutput.
 	// This should be a protected namespace from regular users.
 	// Resources like fluentbit and fluentd will run in this namespace as well.