Skip to content

Commit

Permalink
fix: remove requeue after because it halts all other events from bein…
Browse files Browse the repository at this point in the history
…g reconciled

note: the rate limiter will protect us anyways

Signed-off-by: Peter Wilcsinszky <[email protected]>
  • Loading branch information
pepov committed Feb 28, 2024
1 parent 7f1e67b commit 7fe3a82
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
3 changes: 1 addition & 2 deletions pkg/resources/fluentd/fluentd.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ package fluentd
import (
"context"
"fmt"
"time"

"emperror.dev/errors"
"github.com/cisco-open/operator-tools/pkg/reconciler"
Expand Down Expand Up @@ -203,7 +202,7 @@ func (r *Reconciler) Reconcile(ctx context.Context) (*reconcile.Result, error) {
} else {
r.Log.Info("still waiting for the configcheck result...")
}
return &reconcile.Result{RequeueAfter: time.Minute}, nil
return &reconcile.Result{Requeue: true}, nil
}
}
}
Expand Down
3 changes: 1 addition & 2 deletions pkg/resources/syslogng/syslogng.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ package syslogng

import (
"context"
"time"

"emperror.dev/errors"
"github.com/cisco-open/operator-tools/pkg/reconciler"
Expand Down Expand Up @@ -184,7 +183,7 @@ func (r *Reconciler) Reconcile(ctx context.Context) (*reconcile.Result, error) {
} else {
r.Log.Info("still waiting for the configcheck result...")
}
return &reconcile.Result{RequeueAfter: time.Minute}, nil
return &reconcile.Result{Requeue: true}, nil
}
}
}
Expand Down

0 comments on commit 7fe3a82

Please sign in to comment.