Merge pull request #1858 from kube-logging/chore/headless-svc

chore: use consts instead of literals
kube-logging · Nov 27, 2024 · 691addf · 691addf
2 parents 69e82c2 + 1b405c5
commit 691addf
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 7 deletions.
diff --git a/.gitignore b/.gitignore
@@ -99,3 +99,7 @@ example/tls-cluster-forward/*.key
 .DS_Store
 
 go.work.sum
+
+# Ignore DevSpace cache and log folder and DevSpace configuration file
+.devspace/
+devspace.yaml
diff --git a/pkg/resources/fluentbit/service.go b/pkg/resources/fluentbit/service.go
@@ -39,7 +39,7 @@ func (r *Reconciler) serviceMetrics() (runtime.Object, reconciler.DesiredState,
 				},
 				Selector:  r.getFluentBitLabels(),
 				Type:      corev1.ServiceTypeClusterIP,
-				ClusterIP: "None",
+				ClusterIP: corev1.ClusterIPNone,
 			},
 		}, reconciler.StatePresent, nil
 	}
@@ -107,7 +107,7 @@ func (r *Reconciler) serviceBufferMetrics() (runtime.Object, reconciler.DesiredS
 				},
 				Selector:  r.getFluentBitLabels(),
 				Type:      corev1.ServiceTypeClusterIP,
-				ClusterIP: "None",
+				ClusterIP: corev1.ClusterIPNone,
 			},
 		}, reconciler.StatePresent, nil
 	}

diff --git a/pkg/resources/fluentd/service.go b/pkg/resources/fluentd/service.go
@@ -74,7 +74,7 @@ func (r *Reconciler) serviceMetrics() (runtime.Object, reconciler.DesiredState,
 				},
 				Selector:  r.Logging.GetFluentdLabels(ComponentFluentd, *r.fluentdSpec),
 				Type:      corev1.ServiceTypeClusterIP,
-				ClusterIP: "None",
+				ClusterIP: corev1.ClusterIPNone,
 			},
 		}, reconciler.StatePresent, nil
 	}
@@ -142,7 +142,7 @@ func (r *Reconciler) serviceBufferMetrics() (runtime.Object, reconciler.DesiredS
 				},
 				Selector:  r.Logging.GetFluentdLabels(ComponentFluentd, *r.fluentdSpec),
 				Type:      corev1.ServiceTypeClusterIP,
-				ClusterIP: "None",
+				ClusterIP: corev1.ClusterIPNone,
 			},
 		}, reconciler.StatePresent, nil
 	}

diff --git a/pkg/resources/nodeagent/service.go b/pkg/resources/nodeagent/service.go
@@ -41,7 +41,7 @@ func (n *nodeAgentInstance) serviceMetrics() (runtime.Object, reconciler.Desired
 				},
 				Selector:  n.getFluentBitLabels(),
 				Type:      corev1.ServiceTypeClusterIP,
-				ClusterIP: "None",
+				ClusterIP: corev1.ClusterIPNone,
 			},
 		}
 		err := merge.Merge(desired, n.nodeAgent.FluentbitSpec.MetricsService)

diff --git a/pkg/resources/syslogng/service.go b/pkg/resources/syslogng/service.go
@@ -74,7 +74,7 @@ func (r *Reconciler) serviceMetrics() (runtime.Object, reconciler.DesiredState,
 				},
 				Selector:  r.Logging.GetSyslogNGLabels(ComponentSyslogNG),
 				Type:      corev1.ServiceTypeClusterIP,
-				ClusterIP: "None",
+				ClusterIP: corev1.ClusterIPNone,
 			},
 		}, reconciler.StatePresent, nil
 	}
@@ -141,7 +141,7 @@ func (r *Reconciler) serviceBufferMetrics() (runtime.Object, reconciler.DesiredS
 				},
 				Selector:  r.Logging.GetSyslogNGLabels(ComponentSyslogNG),
 				Type:      corev1.ServiceTypeClusterIP,
-				ClusterIP: "None",
+				ClusterIP: corev1.ClusterIPNone,
 			},
 		}, reconciler.StatePresent, nil
 	}