fix(reconciler): make sure to not update the original object

If the original object contains a pointer, then without this patch that pointer will (inadvertently) change. Co-authored-by: Dudás Ádám <[email protected]> Signed-off-by: Szilard Parrag <[email protected]>
kube-logging · Nov 20, 2023 · 3e5b7d4 · 3e5b7d4
1 parent 5c72338
commit 3e5b7d4
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/pkg/resources/model/reconciler.go b/pkg/resources/model/reconciler.go
@@ -277,7 +277,8 @@ func NewValidationReconciler(
 				continue
 			}
 
-			if err := repo.Status().Patch(ctx, req.Obj, req.Patch); err != nil {
+			obj := req.Obj.DeepCopyObject().(client.Object) // copy object so that the original is not changed by the call to Patch
+			if err := repo.Status().Patch(ctx, obj, req.Patch); err != nil {
 				errs = errors.Append(errs, err)
 			}
 		}