feat: taints and labels per autoscaler nodepool #1012
Conversation
|
@Silvest89 This is great, super needed indeed. As soon as the autoscaler PR merges, we will merge this one. Please let us know. Thanks! |
Silvest89
force-pushed
the
autoscaler-taints-labels
branch
2 times, most recently
from
e03bb94 to
0996a05
Compare
Silvest89
force-pushed
the
autoscaler-taints-labels
branch
2 times, most recently
from
5130e7b to
a80fa62
Compare
Silvest89
force-pushed
the
autoscaler-taints-labels
branch
from
a80fa62 to
62ac1a4
Compare
|
@mysticaltech The autoscaler PR has been approved ;], so will see when it merges. |
Wonderful news! 🙏💙 |
|
@mysticaltech |
|
Sorry @Silvest89, I did not have time to reply today. Super good job 🙏🙏 This weekend I merged all PRs to staging but there was an error when trying to do a test deloy of staging. I need to debug this and then we can merge this. Will try to debug tonight. |
|
Staging now worked! During the week-end when I tried, it was a network error while fetching k3s, maybe one of that service was down at the moment at the very moment I gave it a shot. So merging this for now. We can add more features later! 🚀 |
|
@Silvest89 Now staging deployed but getting this error:
So probably templates/autoscaler.yaml.tpl needs tweaking. A fix would be super appreciated! 🙏 |
|
The changes remains on staging, but I just deployed all previous PRs in v2.8.3; we will release v2.9.0 along with the fix 🚀 |
|
Ah right, this is because you still run with the old autoscaler 🤭 will push the fix later today |
I found that the autoscaler support for taints and labels was very very lacking! The autoscaler predicate didn't know before hand the taints and labels of the nodepools . And there was no support of taints/labels per nodepool.
This also makes it so that multi arch node pools are possible! I have been running this a month or so~ and no quirks 👯
This PR goes hand in hand with a PR in autoscaler. eg breaking-change
kubernetes/autoscaler#6184