Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix in wait option for conditions #700

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Bug fix in wait option for conditions #700

merged 1 commit into from
Sep 23, 2024

Conversation

vishnuchalla
Copy link
Collaborator

@vishnuchalla vishnuchalla commented Sep 19, 2024

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

Bug fix in wait options that was previously overlooked. This PR is pre-requisite of #698

Related Tickets & Documents

Testing

PR CI tests. Also verified by testing through gh actions: https://github.com/vishnuchalla/kube-burner/actions/runs/10927130633/job/30332622126

Copy link
Member

@rsevilla87 rsevilla87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@rsevilla87 rsevilla87 merged commit 2408748 into kube-burner:main Sep 23, 2024
7 checks passed
rsevilla87 pushed a commit that referenced this pull request Sep 25, 2024
## Type of change

- [ ] Refactor
- [x] New feature
- [x] Bug fix
- [ ] Optimization
- [ ] Documentation Update

## Description
Adding kube-virt into the CI. This will help us deploy VMs and validate
our code against them. Pre-requisite:
#700

## Related Tickets & Documents
- Closes # https://issues.redhat.com/browse/PERFSCALE-3400?filter=-1

## Testing
Tested and verified the lifecycle through fork github actions:
https://github.com/vishnuchalla/kube-burner/actions/runs/10927130633/job/30332622126

Signed-off-by: Vishnu Challa <[email protected]>
Co-authored-by: Vishnu Challa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants