add connectivity check via svc in readiness probe #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsevilla87
reviewed
Nov 19, 2024
mohit-sheth
force-pushed
the
udn-readiness
branch
from
f837459 to
f6712fd
Compare
now the l2 and l3 parts are merged so it should be good |
Signed-off-by: Mohit Sheth <[email protected]>
mohit-sheth
force-pushed
the
udn-readiness
branch
from
f6712fd to
4fe4823
Compare
|
@mohit-sheth Do you have plans to add a functional test to this workload in the |
Merging as per the conversation offline, to add tests after 4.18 release as this requires a featuregate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding readiness probe which tries to connect to the server pod via the service endpoint
Routes support is not in yet for UDN
Checklist before requesting a review