Deprecate --profile-type flag #147
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsevilla87
force-pushed
the
deprecate-profile-type
branch
from
083bf77 to
d4f099a
Compare
Signed-off-by: Raul Sevilla <[email protected]> Update tests Signed-off-by: Raul Sevilla <[email protected]>
Signed-off-by: Raul Sevilla <[email protected]>
Signed-off-by: Raul Sevilla <[email protected]>
Signed-off-by: Raul Sevilla <[email protected]>
Signed-off-by: Raul Sevilla <[email protected]>
rsevilla87
force-pushed
the
deprecate-profile-type
branch
from
5df4022 to
40b15af
Compare
|
Seems to be a breaking change. Needs to go in a dedicated release under detailed supervision. Can we have all the repos/CI systems impacting by this change first to start with? |
yes, it's a breaking change, we can work on it in another release, there's no rush to have it soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
The flag --profile-type can be deprecated thanks to the new flag --metrics-profile that allows a list of files.
Related Tickets & Documents
Checklist before requesting a review