vmm:qemu support aarch64 #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
Burning1020
requested changes
Oct 23, 2024
vmm/sandbox/src/qemu/config.rs
Outdated
| @@ -21,7 +21,7 @@ use std::{ | |||
| }; | |||
|
|
|||
| use containerd_sandbox::error::{Error, Result}; | |||
| #[cfg(target_arch = "x86_64")] | |||
| #[cfg(any(target_arch = "x86_64", target_arch = "aarch64"))] | |||
There was a problem hiding this comment.
Is this cfg not needed anymore after aarch64 is supportted? If so, you can remove it.
vmm/sandbox/src/qemu/config.rs
Outdated
| lazy_static! { | ||
| static ref SUPPORTED_MACHINES: HashMap<String, Machine> = { | ||
| let mut sms = HashMap::new(); | ||
| #[cfg(target_arch = "x86_64")] | ||
| sms.insert( | ||
| "microvm-pci".to_string(), | ||
| Machine { | ||
| r#type: "microvm-pci".to_string(), |
There was a problem hiding this comment.
"microvm-pci" is not needed, can you help remove?
vmm/sandbox/src/qemu/config.rs
Outdated
| @@ -155,17 +165,17 @@ impl QemuVMConfig { | |||
| } else { | |||
| return Err(Error::InvalidArgument("cpu model".to_string())); | |||
| } | |||
| #[cfg(target_arch = "x86_64")] | |||
| #[cfg(any(target_arch = "x86_64", target_arch = "aarch64"))] | |||
Signed-off-by: liuxu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vmm:qemu support aarch64