build: add some commands and make build.sh independent #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Burning1020
commented
Apr 8, 2024
Burning1020
commented
- add some command binaries for debug in vm
- build.sh is for docker/ctr/isula to prepare guest rootfs and build it to image or initrd, thus it should not have any difference with each guest os.
|
release workload on my repo: https://github.com/Burning1020/kuasar/actions/runs/8599916269 |
Burning1020
changed the title
1. add some command binaries for debug in vm 2. build.sh is for docker/ctr/isula to prepare guest rootfs and build it to image or initrd, thus it should not have any difference with each guest os. Signed-off-by: Zhang Tianyang <[email protected]>
morningtzh
reviewed
Apr 9, 2024
| @@ -7,6 +7,9 @@ | |||
| /usr/bin/sh /bin | |||
| # procps-ng | |||
| /usr/bin/ps /bin | |||
| /usr/bin/kill /bin | |||
| /usr/bin/free /bin | |||
| /usr/bin/top /bin | |||
There was a problem hiding this comment.
How much will these binaries add to the total image size?
There was a problem hiding this comment.
Approximately 1~2M, the total size of image file in still 128M,
| fi | ||
| array=($(rpm -ql $rpm | grep -v "share" | grep -v ".build-id")) | ||
| for file in ${array[@]}; do | ||
| source=$file | ||
| dts_file=${rootfs_dir}$file | ||
| dts_folder=${dts_file%/*} | ||
| if [ ! -d "$dts_folder" ]; then | ||
| if [ ! -d "$dts_folder" ] && [ ! -L "$dts_folder" ]; then |
There was a problem hiding this comment.
Under what circumstances is the dts_ folder a symbolic link?
There was a problem hiding this comment.
/bin links to /usr/bin, in this condition, make directory for /bin is failed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.