Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Past around 500 tags the Tag Block List will not save #8

Closed
Azriel-Satan opened this issue Jul 18, 2024 · 6 comments
Closed

Past around 500 tags the Tag Block List will not save #8

Azriel-Satan opened this issue Jul 18, 2024 · 6 comments
Labels
question Further information is requested

Comments

@Azriel-Satan
Copy link

Azriel-Satan commented Jul 18, 2024

  • Changes to the Block List textbox are not saved if more than 500 tags are inputted.
  • This limitation is present when using both newlines and spaces.
  • 500 is not an exact limit, but it functions there and not at 600.

I am an unusual case as I maintain a very long list of artists I have Blocked (currently standing at 1874 artists totaling 2036 tags) and use the Block List function to exclude followed artists when looking for new ones (totaling 2856 tags). In attempting to use to tag blacklist from Booru Sushi to get around sites that do not have functional Block Lists (Rule34) or have aggressive Cloudflare settings (Gelbooru), I discovered that somewhere past the 500 mark, it would not save inputs made to the blocklist.

@kuanyui
Copy link
Owner

kuanyui commented Jul 18, 2024 via email

@Azriel-Satan
Copy link
Author

@kuanyui
Copy link
Owner

kuanyui commented Jul 19, 2024 via email

@kuanyui kuanyui added the question Further information is requested label Aug 6, 2024
@kuanyui
Copy link
Owner

kuanyui commented Aug 26, 2024

No more response, no more information, close as invalid issue.

@kuanyui kuanyui closed this as not planned Won't fix, can't repro, duplicate, stale Aug 26, 2024
@Azriel-Satan
Copy link
Author

Azriel-Satan commented Aug 27, 2024

I run Librewolf as my Main.
Installed a Fresh instance of Firefox Version 129.0.2 and pasted my block list; despite the Settings Saved popup, it returns to the previous state when the tab is reloaded.
Testing it, I was able to save up to 566 tags, but further attempts saw that I was able to save part of the next tag; the most I could get it to store was 5759 characters; past that point, no changes are kept. Removing the filename template allowed additional tags to be added, so its possible there is a hard limit.
Removing the Filename template allows additional characters to be added equal to the Filename template's length.
BooruShinshiSettings_20240826_225113.json

@kuanyui
Copy link
Owner

kuanyui commented Oct 26, 2024

OK found where the problem is. It's browser.storage.sync has quota limit. Your setting is too large so out of quota. From BooruShinshi 0.12.0, it always use browser.storage.local to save settings. However this means the BooruShinshi's settings will no longer be backed-up & synchronized by Mozilla Account.

Don't` ask me to add an option to let user switch between sync/local, it's too troublesome. Please backup your settings by yourself.

5c35653

@kuanyui kuanyui closed this as completed Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants