Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remote monad latest" #90

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jtdawso
Copy link
Member

@jtdawso jtdawso commented Mar 12, 2018

Reverts #89
Further discussion needed before merging

@jtdawso
Copy link
Member Author

jtdawso commented Mar 12, 2018

@RyanGlScott thanks for looking at the pull request that I merged. I merged a little quickly when it looks like things were not complete and further discussion is needed.

In the latest version of the remote monad we basically need to decide if we care about the Strong Bundling. It has been awhile since I looked at the refactor of the RemoteMonad library to take 1 parameter instead of 2 (Command and Procedure). I think when the refactor happened the types were not very happy for the Strong Monad. In the presence of the Applicative Bundling there really isn't an advantage of having the strong monad. @andygill Do we want to wipe out the strong version of things and leave weak, applicative and alternative?

As far as the audio and playbar examples. I have never been able to get them to work. If someone else has, then it would be great to get them working.

I think these were the main reasons why I didn't merge initially and then I forgot about them when I hastily merged the above pull request.

@RyanGlScott
Copy link
Member

No worries! To be clear, I wasn't necessarily suggesting to revert that commit—those were just some comments to consider after it had landed. If you want to revert and discuss more, that's fine too.

I can take a look at the audio examples, because I do remember that was in a working state at one point. (Perhaps modern web browsers treat audio playback differently, though.)

@RyanGlScott
Copy link
Member

So I just tried the audio examples, and interestingly enough, they audio works perfectly for me. (I'm using Firefox 57.0.4 on Linux, if that makes a difference.)

However, I did notice that blank-canvas' framerate is a lot worse. Even on the simple rotating square example, the image noticeably lags when refreshing. Is this a known issue?

@jtdawso
Copy link
Member Author

jtdawso commented Mar 12, 2018

I'm glad that the audio seems to be working. The frame rate dip you are experiencing is the difference between the weak and the strong remote monad. We can either get the strong working again, or wait for Andy's changes to get the applicative working since the strong monad is obsolete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants