Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid duplicate declaration error when a file already imports Vue #3

Merged
merged 1 commit into from
Mar 17, 2017

Conversation

Toilal
Copy link
Contributor

@Toilal Toilal commented Mar 17, 2017

I hit an issue with one of my JS file that already import the Vue object causing a duplicate import, so I made this change as both vue-loader and vue-template-loader do this.

It seems to work really fine now, but maybe you could add a notice in readme to disable hmr from vue-template-loader when using both loaders.

Copy link
Owner

@ktsn ktsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ktsn ktsn merged commit f4bd9c8 into ktsn:master Mar 17, 2017
@ktsn
Copy link
Owner

ktsn commented Mar 17, 2017

Published as v0.1.2

@Toilal Toilal deleted the feature/fixes branch March 21, 2017 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants