Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SourceMap broken #4

Closed
Toilal opened this issue Mar 21, 2017 · 2 comments
Closed

SourceMap broken #4

Toilal opened this issue Mar 21, 2017 · 2 comments

Comments

@Toilal
Copy link
Contributor

Toilal commented Mar 21, 2017

When using this loader on TypeScript, sourcemaps are broken making debuging impossible.
@Toilal
Copy link
Contributor Author

Toilal commented Mar 21, 2017

To reproduce, vue init https://github.com/Toilal/vue-webpack-template vue-test-sourcemaps (Choose typescript on generation). In the generated project, run npm run dev and then try to debug a TypeScript file inside the browser.

@Toilal Toilal changed the title TypeScript sourceMap broken SourceMap broken Mar 21, 2017
@Toilal
Copy link
Contributor Author

Toilal commented Mar 21, 2017

Same issue without TypeScript, using Babel. I think it's because of escodegen, we need to handle sourcemap when calling generate: https://github.com/estools/escodegen/wiki/Source-Map-Usage.

Toilal added a commit to Toilal/vue-hot-reload-loader that referenced this issue Mar 21, 2017
@Toilal
Add support for sourcemap
c632bfd 
Close ktsn#4
@Toilal Toilal mentioned this issue Mar 21, 2017
Merged
Toilal added a commit to Toilal/vue-hot-reload-loader that referenced this issue Mar 21, 2017
@Toilal
Add support for sourcemap
6653bb9 
Close ktsn#4
Toilal added a commit to Toilal/vue-hot-reload-loader that referenced this issue Mar 21, 2017
@Toilal
Add support for sourcemap
25dceec 
Close ktsn#4
@ktsn ktsn closed this as completed in #5 Mar 22, 2017
ktsn pushed a commit that referenced this issue Mar 22, 2017
@Toilal @ktsn
Add support for sourcemap (#5)
b9357ee 
* Add support for sourcemap

Close #4

* Add support for loader sourceMap option and generate sourcemap from scratch when previous sourcemap is undefined

* Avoid defining location/sourceFile parse options when sourceMap is falsy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Toilal