Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Head argument is ignored when --columns are specified #22

Closed
exaspace opened this issue Dec 24, 2021 · 1 comment · Fixed by #23
Closed

Head argument is ignored when --columns are specified #22

exaspace opened this issue Dec 24, 2021 · 1 comment · Fixed by #23

Comments

@exaspace
Copy link
Contributor

For both csv and show actions, when the --columns argument is supplied, the --head value is ignored and all rows are presented.
@exaspace
Copy link
Contributor Author

Pull request #23 is raised to fix this. The fix is very simple and the existing test cases have been extended to verify the --head argument is honoured.

$ git co fix-head-argument
$ poetry run pytest --quiet tests/
...............................................                                                                            [100%]
47 passed in 4.67s

@ktrueda ktrueda linked a pull request Dec 25, 2021 that will close this issue
Fix: honour --head when --columns is provided. #23
Merged
ktrueda pushed a commit that referenced this issue Dec 25, 2021
@exaspace
Fix: honour --head when --columns is provided. (#23)
32390a1 
This fix ensures that only the number of rows specified by the client
will be output when the --columns argument is supplied (fixes
#22).
ktrueda added a commit that referenced this issue Dec 25, 2021
@ktrueda
v.0.2.10
6c064da 
closes #22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: honour --head when --columns is provided.
1 participant
@exaspace