Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated "ioutil" and fix notes #622

Merged
merged 3 commits into from
Feb 6, 2023
Merged

Conversation

asjdf
Copy link
Contributor

@asjdf asjdf commented Jan 13, 2023

No description provided.

Copy link
Owner

@ktr0731 ktr0731 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. I suggested a change.

repl/repl_test.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Merging #622 (e9be9c4) into master (2856945) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #622   +/-   ##
=======================================
  Coverage   80.01%   80.01%           
=======================================
  Files          57       57           
  Lines        3858     3858           
=======================================
  Hits         3087     3087           
  Misses        542      542           
  Partials      229      229           

Copy link
Owner

@ktr0731 ktr0731 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your contribution!

@ktr0731 ktr0731 merged commit 5f3b4c5 into ktr0731:master Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants