Add support for --bytes-as-base64

[flokli]

This allows entering bytes as a base64-encoded string, using the standard encoding.

Suggested in #610

[flokli]

I tried extending fill/proto/interactive_filler_test.go with an additional field, but I don't understand the test harness enough to understand how to test the filler with other filler opts just for one field. It must work somehow, because we fill bytes passed in there, and read from ./proto.go file.

@ktr0731, @BenSlabbert, any thoughts?

[flokli]

Hmmh, we output bytes as base64, like grpcurl does. It would feel much more natural if this was the default TBH.

[flokli]

poke @ktr0731 . WDYT?

Happy to rework this patch to accept bytes as base64 by default, if you prefer that.

[codecov]

Codecov Report

Merging #611 (c84378e) into master (f75862c) will decrease coverage by 0.16%.
The diff coverage is 55.55%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #611      +/-   ##
==========================================
- Coverage   80.17%   80.01%   -0.16%     
==========================================
  Files          57       57              
  Lines        3848     3858      +10     
==========================================
+ Hits         3085     3087       +2     
- Misses        536      542       +6     
- Partials      227      229       +2     

[ktr0731]

Sorry for the delay. The content is very informative, LGTM, thank you!

[flokli]

Thanks for the merge! What's your opinion on making base64 input for bytes the default, to be symmetrical with the output? (As in #611 (comment) )

[ktr0731]

Oh, I missed that 🙏
Sounds good. I was worried about backward compatibility, but we can still use the input as is (just like the change in this PR does). Can you give this a shot?

[ktr0731]

You can revert your merged changes since I haven't released a new version yet.

[flokli]

I'm not sure I understand the task exactly.

I honestly doubt someone is using byte literals or unicode literals to enter bytes (especially considering we output base64).

My proposal would be to accept base64 by default, (keep --bytes-from-file), and introduce a (--bytes-literal) argument bringing back the old behaviour.

[flokli]

This is implemented in #631, PTAL.